GNOME Bugzilla – Bug 118474
gstputbits should be rewritten
Last modified: 2004-12-22 21:47:04 UTC
The gstputbits plugin (gstreamer/gst/putbits/putbits.[ch]) are under the MPEG lciense. This license clearly states that there may be IP in the code. No plugin in the core should be under any license that is not LGPL. This plugin should be rewritten so it can be under the LGPL, or moved to gst-plugins. According to my conversations with Wim Taymans, the putbits plugin is only used by mpegaudio and mpeg2enc.
Does anything use it that shouldn't be dropped?
only gst-plugins/gst/mpegaudio and mpeg2enc use it. Attached is a patch to move putbits.[ch] to the mpegaudio and mpeg3enc directories (curiously, the code base that it came from.) I favor dumping gstreamer/libs/gst/putbits, and telling people to use bitstream in codecs.org.
Created attachment 18706 [details] [review] patch to add putbits.[ch] in places where it's needed
The patch has been committed, and the lib removed from gstreamer.