After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 117458 - cdplayer applet to use "media-*" as stock-ids
cdplayer applet to use "media-*" as stock-ids
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cdplayer
2.0.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
AP2
Depends on:
Blocks:
 
 
Reported: 2003-07-15 12:27 UTC by Rajkumar
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4

Attachments
Patch as stated above. (1.25 KB, patch)
2003-07-15 12:33 UTC, Rajkumar 		none Details | Review

Description Rajkumar 2003-07-15 12:27:06 UTC 
Cdplayer applet uses "cdplayer-*" (i.e., cdplayer-stop, cdplayer-play,
etc.) as stock-ids to fetch the themed icons supplied by GtkThemes. These
themed icons supplied by the GtkThemes are common for other media
applications like grecord, gnome-cd etc. hence it would make more sense if
all these applications uses common stock-ids there by avoiding redundant
entries in theme rc files.

I think "media-*" can be commonly used by all these *media* applications.
Comment 1 Rajkumar 2003-07-15 12:32:17 UTC 
I worked out a patch which swaps "cdplayer-*" with "media-*". Once we
agree upon this and commit, gnome-themes should be patched to use
media-* (spoke to Calum and he has agreed for this gnome-themes
change).
Comment 2 Rajkumar 2003-07-15 12:33:03 UTC 
Created attachment 18305 [details] [review]
Patch as stated above.
Comment 3 Kevin Vandersloot 2003-07-16 23:13:35 UTC 
Looks good. Please commit. Thanks!
Comment 4 Rajkumar 2003-07-17 05:12:40 UTC 
Kevin, patch committed to HEAD. Thanks!

----------
2003-07-17  Rajkumar Sivasamy <rajkumar.siva@wipro.com>

        * cdplayer.c: cdplayer applet to use "media-*" as stock-ids.
        Fixes bug #117458.