GNOME Bugzilla – Bug 116944
[PATCH] HIGify the various dialogs
Last modified: 2004-12-22 21:47:04 UTC
Hi Rich, I am attaching a patch to improve the HIGification of the edit constants, edit functions, and insert ASCII value dialogs. I will also attach screenshots. Let me know what you think. Take care, Dennis
Created attachment 18121 [details] [review] A patch file.
Created attachment 18122 [details] Screenshot #1.
Created attachment 18123 [details] Screenshot #2.
Thanks Dennis. (Adding Calum to the bug report). Calum, you okay with these changes? I'm guessing as they are visual changes (and I've just missed the UI freeze), that they will have to wait until GNOME 2.5/6.
From the 2.3 schedule, "July 7 - UI freeze - UI review period heats up. Changes to user interface may only be made in response to UI review bugs (HIG compliance, consistency, etc)." I would think these UI changes would fall into the HIG compliance category.
Okay Calum, thanks. Changes checked in. Fixed in v4.2.98. Note that I made a few slight adjustments to the patch as given. I removed tabs (tabs are evil), reduced line widths to less than 80 columns (to make it more readable), and adjusted code to the OneTrueStyle(TM). I also made the minimum width for the edit constant/function popup to be 380 (from 360) so you don't immediately have a horizontal scrollbar for the default constant values (because of the long description for the first one). I note that the "Note" part of the label telling the user that the constants are in decimal base, doesn't show up as bold on my Solaris box, but should do according to the <b> ... </b> tags in the string. Strange. Breda, I've cc"ed you on this bug in case you need to make any changes to the gcalctool online help for this. Thanks.
Hi Rich, I've finally managed to build gcalctool V4.2.98 and check this bug. As we no longer include screenshots of the Edit Constants, Edit Functions, or Insert ASCII dialogs, I don't think this bug affects the online help. Or am I missing the point? Btw, the "Note" text does appear in bold on my Linux box. However, I did make some small updates to the Constants section of the online help: o Previously: C1, C2, and C3 displayed 10 decimal places. Now: Changed each to 9 decimal places. o Previously: C4 displayed the inverse value (2.5). Now: Changed value and updated associated text accordingly. o Previously: C5 and C6 displayed trailing zeroes. Now: Removed trailing zeroes. I'll send you the updated doc file shortly, for review. Regards, Breda.
Changes made in gcalctool Manual V2.5, now committed into CVS :)