GNOME Bugzilla – Bug 116416
vorbis metadata: use fields compatible with most players
Last modified: 2004-12-22 21:47:04 UTC
The current code doesn't set the fields with the right names for use with most players. Patch attached
Created attachment 17946 [details] [review] fix
marking 0.6.3, so it gets in there. HEAD will be fixed differently.
When discussing this with the xiph guys, they specifically mentioned the comment field should remain free-form and that there is no definitive list of tags standardized on. Which list of tags did you base yourself on, can you argument this a little so we know if we're making the right change, since this is arguably a (minor) interface change ?
These are the field names used by ogg123, xine, mplayer, xmms, etc. Sound-juicer was using the fact that the fieldnames weren't checked for to use the fieldnames like "TITLE", etc.
Created attachment 18059 [details] [review] doh comment=COMMENT ;)
Created attachment 18065 [details] [review] upper case the field names to work-around bugs in broken players
Created attachment 18066 [details] [review] too drunk to code
commited to 0.6.2.1, closing.