GNOME Bugzilla – Bug 115239
Profiles for mail/news don't get selected according to post type
Last modified: 2004-12-22 21:47:04 UTC
I set up two profiles: one for use with mail, the other for use with newsgroups, checking the "make this the default profile" box as appropriate. (the only difference is that the newsgroup profile has 'NOSPAM' in my mail address) But whether posting using 'post to/followup to newsgroup' or 'reply by email' only the mail profile gets used - no message has "NOSPAM" in the address. If I reverse the checkboxes (mail profile==prev. 'NOSPAM' default for news, news profile==prev. 'clean address' default for mail), then 'post to/followup' uses the mail profile (no "NOSPAM"), but 'reply by mail' now selects the profile according to the checkbox and I get "NOSPAM" in my mail address. (obviously this is the reverse of what I intended - I just hope it might provide you with a clue) Actually, if I set up a profile as the default for mail and news (checking both boxes) and create a second profile but check no "use as default" boxes, this second profile still gets used during reply by mail only - even though it shouldn't be used at all. Er, I *think* that's clear...
confirmed. Chris: the problem here is that the group's default profile is overriding the `default identity for news' and `default identity for mail' settings, which is the Right Thing, but confusing. I think the problem here is that the implicit approach from the `use the last identity' method and the explicit approach from the `make this the default' method are in conflict. I'm leaning right now towards removing the "make this the default for mail" and "make this the default for posting" checkboxes from the identity editor and having it all be implicit: determine_default_identity () { if (user is sending mail && user has sent mail before) { identity = previous_identity_from_sending_mail } else if (user is posting) { if (user has posted to this group before) { identity = previous identity from this group } else if (user has ever posted before to any group) { identity = previous identity from any posting } } if (identity == NULL) identity = the first one in the identity list } How does this sound?
Sounds good.
Chris: I'd appreciate it if you could review my changes. http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/identities&command=DIFF_FRAMESET&file=identity-ui.c&rev1=1.20&rev2=1.21&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/identities&command=DIFF_FRAMESET&file=identity-manager.h&rev1=1.9&rev2=1.10&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/identities&command=DIFF_FRAMESET&file=identity-manager.c&rev1=1.20&rev2=1.21&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/identities&command=DIFF_FRAMESET&file=identity-edit-ui.h&rev1=1.5&rev2=1.6&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan/identities&command=DIFF_FRAMESET&file=identity-edit-ui.c&rev1=1.28&rev2=1.29&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan/pan&command=DIFF_FRAMESET&file=message-window.c&rev1=1.373&rev2=1.374&root=/cvs/gnome http://cvs.gnome.org/bonsai/cvsview2.cgi?diff_mode=context&whitespace_mode=show&subdir=pan&command=DIFF_FRAMESET&file=ChangeLog&rev1=1.1904&rev2=1.1905&root=/cvs/gnome
Reviewed. Looks fine.