GNOME Bugzilla – Bug 114117
Change chunking behavior
Last modified: 2004-12-22 21:47:04 UTC
As discussed on gnome-doc-list, I'd like to change the chunking behavior of Yelp so that divisions are either in their own chunk, or they're displayed inline in their parent division, but never both. I've attached a patch to do this. This patch is a fairly extensive overhaul of Yelp's stylesheet customizations. The relevant gnome-doc-list thread is here: http://mail.gnome.org/archives/gnome-doc-list/2003-May/msg00036.html
Created attachment 17006 [details] [review] Overhaul of Yelp's stylesheet customizations
Created attachment 17008 [details] Additional file required by new stylesheet customizations.
That patch gets Prev/Next links wrong in a few cases. I'm attaching a patch that doesn't suck as badly.
Created attachment 17012 [details] [review] Stylesheet overhaul with better Prev/Next link handling
Submitting yet another improved patch. The Next link on the TOC was unchanged from the old stylesheets, which was broken. That's fixed. And href.target was unchanged, which causes stuff like the preface and glossary of AisleRiot not to be properly linked to. That's also fixed.
Created attachment 17021 [details] [review] Still more improvements on the new stylesheets.
OK, that's not quite right either. The last patch breaks stuff for the User's Guide. I don't like the rather hacked way the User's Guide is registered, but there's not much I can do about it right now other than work around it. I'm attaching yet another patch which fixes this and another little bug in the Previous links. This also involves an extra function in yelp-functions.xsl, so I'm attaching a new version of that as well. Sorry for all the noise here.
Created attachment 17033 [details] [review] Improved improved new stylesheets.
Created attachment 17034 [details] Updated set of functions for improved improved new stylesheet.
Since Yelp can't scroll to fragments, the sidebar is a bit broken with these stylesheets. Specifically, the sidebar may show nodes which are deeper than these stylesheets chunk. Since there's no chunk for them, Yelp throws the whole document at you, which is unpleasant. I'm attaching a patch that restricts the depth of the sidebar to be consistant with how the document is chunked.
Created attachment 17300 [details] [review] Restrict depth of nodes in the sidebar.
Shaun - In terms of the "rather hacked way the User's Guide is registered," to borrow your apt description - The 2.4 release offers a chance to change things if you've an alternative approach. Also, do you have a cvs account yet so you can check things in yourself?
I don't think I could change the way the User's Guide is registered very well before the feature freeze in four hours. With my stylesheets, registering the chapter directly would almost work, but you wouldn't get the front matter. I'm not sure how widespread this "transparent part" stuff is, but I've never seen it used elsewhere. However, Scrollkeeper does support it for the TOC. (Also, I should change my support of it to match Scrollkeeper's, i.e. thread over id-less parts. That's a trivial change, and it's also less messy.) I don't have a CVS account. Should I email accounts and ask for one?
I meant to elaborate more on the way the User's Guide is registered with Scrollkeeper. Note that registering chapters instead of parts still doesn't fix #111886. I think the best solution would be to register the whole file and a fragment identifier of some sort, preferably with XPointer. But I can't do that in time for the feature freeze.
Shaun's omnibus patch is checked in.
Can I close this one now (and therefore also 98805 and 98361)?