After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113764 - Support a non ASCII dictionary
Support a non ASCII dictionary
Status: RESOLVED FIXED
Product: gok
Classification: Deprecated
Component: general
unspecified
Other All
: Normal major
: ---
Assigned To: bill.haneman
bill.haneman
2.4-STRING-FREEZE
Depends on:
Blocks: 122112
 
 
Reported: 2003-05-26 21:00 UTC by simon.bates
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.3/2.4



Description simon.bates 2003-05-26 21:00:47 UTC
I recently spoke with Gunnar Schmidt and Olaf Jan Schmidt of KDE
accessibility and they told me that they are using the GOK dictionary file
for word completion within KDE. However they did raise one issue: currently
the dictionary file does not specify its encoding. It would probably be
good to give the dictionary file and internationalization a bit of thought.
What encoding are we currently (implicitly) assuming the file is in? How
should we handle different character sets? Only support UTF-8 or extend the
dictionary file to include a declaration of its encoding?
Comment 1 bill.haneman 2003-05-26 21:14:58 UTC
I think we should use UTF-8; but there'd be no harm in putting in a
header of some sort to make this explicit.
Comment 2 bill.haneman 2003-05-26 21:15:58 UTC
I meant to say, we are currently assuming UTF-8 I think; if not I
think we should since it's ASCII compatible.
Comment 3 Olaf Jan Schmidt 2003-05-28 05:33:28 UTC
In KMouth, we also use UTF-8, so if you you that as well, the format is 
identical. 
Comment 4 bill.haneman 2003-05-28 12:22:32 UTC
I think that all that's required here is to make sure that we are
using UTF8-compatible functions for reading and writing the GOK
dictionaries.

glib provides plenty of them so this should be an easy fix; we just
need to revise gok/word-complete.c to use UTF8 routines for parsing
the dictionary, and use appropriate editors for revising it.

Comment 5 bill.haneman 2003-06-28 13:15:39 UTC
This will require some revision (and testing!) of gok/word-complete.c
I think gok/gok-word-complete.c is already UTF-8 ready now, but not
100% sure.

Let's try and do this before 2.4 string freeze, so the translators
might be able to help us here.
Comment 6 bill.haneman 2003-09-10 12:33:30 UTC
bumping up severity since it blocks usefulness of localization.
Comment 7 bill.haneman 2003-10-09 16:46:30 UTC
adding accessibility keyword
Comment 8 bill.haneman 2003-10-10 13:19:34 UTC
fix for this included in work on bug 107200. We can now import UTF-8
dictionaries (as well as ISO-8865-1 dictionaries) in the gok_i18n branch.
Comment 9 bill.haneman 2003-10-10 13:23:31 UTC
I think it would be advisable to include the encoding in the first
line of the GOK dictionary; i.e.

WPDictList UTF-8

Comment 10 bill.haneman 2003-11-04 13:40:37 UTC
fixed in HEAD.