After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113624 - Fixes for dateedit.[hg|ccg]
Fixes for dateedit.[hg|ccg]
Status: RESOLVED FIXED
Product: libgnomeuimm
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gtkmm-forge
gtkmm-forge
Depends on:
Blocks:
 
 
Reported: 2003-05-24 04:34 UTC by Bryan Forbes
Modified: 2011-01-16 23:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
my patch :) (diff file) (7.56 KB, patch)
2003-05-24 04:35 UTC, Bryan Forbes 		none Details | Review

Description Bryan Forbes 2003-05-24 04:34:24 UTC 
I like the new constructors Murray, but here are some fixes that compile
and work.  Also, there were some comments that were out of their blocks so
I fixed that as well.
Comment 1 Bryan Forbes 2003-05-24 04:35:07 UTC 
Created attachment 16794 [details] [review]
my patch :) (diff file)
Comment 2 Murray Cumming 2003-05-26 15:24:54 UTC 
That looks good. Please apply.

But re. the unrelated documentation change about a memory leak - that
sounds like something that should be in bugzilla rather than our
reference docs. Please don't just apply that as it is.
Comment 3 Bryan Forbes 2003-05-26 16:30:49 UTC 
What change about a memory leak?  Link?
Comment 4 Murray Cumming 2003-05-27 05:46:46 UTC 
Hmm, maybe it was there already:
"This allocates some memory that will only be release when the app is 
destroyed".
I just realised why you changed those lines - I tried some 
doxygenization at the same time. Nevermind. Thanks.
Comment 5 Murray Cumming 2003-05-27 05:56:31 UTC 
Oh, and please feel free to apply any approved patches. It would be
really helpful.
Comment 6 Murray Cumming 2003-05-29 17:32:24 UTC 
Applied. Thanks.