GNOME Bugzilla – Bug 113590
vte and AtkText selection
Last modified: 2005-08-10 13:29:32 UTC
It does not seem possible to implement atkText selection methods for VteAccessible as the selection information is hidden away in the bVteTerminalPrivate data structure.
Marking AP1 to reflect a11y team's assessment of a11y impact.
wow, this is very serious indeed.
I am having a look at this.
Created attachment 18412 [details] [review] Proposed patch
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME bug list :)
There's a patch moldering for this... can we get a review from the maintainer(s)? thanks. Or did we just forget to close this?
ping, ping... nalin, is Padraig's patch acceptable?
Created attachment 21826 [details] [review] Updated patch so it applies to CVS HEAD
43, 50, 65, 80: need newline between return type and function name. Try to be consistent with the rest of the module. 59, 62, 74, 77, 174, 197, 202, 204, 258, 283, 287, 290: braces around "then" clause. Try to be consistent with the rest of the module. 266: braces around "else" clause. Try to be consistent with the rest of the module. 50, 135, 342, 364, 430, 437, 438, 439, 440, 464, 469, 491 518, 519: remove whitespace after function name. Try to be consistent with the rest of the module. 491: group separate portions of the expression in parentheses. In _vte_terminal_select_text, the section which determines whether we should be selecting by character, word, or line looks broken -- my understanding of the AtkText data model is that selection-by-character is the only supported means, anything else is a hack.
Created attachment 27419 [details] [review] Reworked patch I have attemtped to address your comments. I was confused by references to line numbers greather than 314 as the patch only has that number of lines. I have removed the determination of selection method in _vte_terminal_select_text. Its purpose was to attempt to select by line or word if that was possible on the assumption that it would be more efficient that to select by character if a large amount of text was to be selected. This updated patch also contains patch for bug #138653.
Created attachment 27420 [details] [review] Correct reworked patch The previous patch was wrong.
Nalin: comments please on Padraig's new patch...
This should be looked at for inclusion in the next cycle I guess. Nalin?
Apologies for spam-- ensuring Sun a11y team are cc'ed on all current a11y bugs. Filter on "SUN A11Y SPAM" to ignore.
Patch still applies except the ChangeLog entry...
This patch is important for GOK and screenreader users.
Bill, Padraig: Has this patch been tested in any of your packages for some time? If it has I'd say we should just commit it and get it resolved once and for all.
We've been testing with the patch for many months now.
Created attachment 50522 [details] [review] updated patch for HEAD I had to manually update the patch some since it had rejects in vte.c. Attaching the commited version here.
Commited.