After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 113161 - Warnings about loading spinner pixbuf
Warnings about loading spinner pixbuf
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Marco Pesenti Gritti
Marco Pesenti Gritti
Depends on: 113859
Blocks:
 
 
Reported: 2003-05-17 01:12 UTC by Havoc Pennington
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Havoc Pennington 2003-05-17 01:12:26 UTC 
** (epiphany-bin:27312): CRITICAL **: file ephy-spinner.c: line 449
(ephy_spinner_load_images): assertion `path != NULL' failed
 
(epiphany-bin:27312): GdkPixbuf-CRITICAL **: file gdk-pixbuf.c: line 373
(gdk_pixbuf_get_width): assertion `pixbuf != NULL' failed
 
(epiphany-bin:27312): GdkPixbuf-CRITICAL **: file gdk-pixbuf.c: line 389
(gdk_pixbuf_get_height): assertion `pixbuf != NULL' failed
Comment 1 Marco Pesenti Gritti 2003-05-17 22:51:48 UTC 
Epiphany is using the gnome nautilus spinner. We are trying to detect
the prefix where nautilus is installed. This is for some reasong
failing on your system (maybe nautilus not installed ?).
I think the right solution is to find a better way to share spinners
with nautilus, maybe using the new icon api Alex hacked. I'll try to
look at the spec and talk with Alex/nautilus developers about it.
The main problem is that spinner is not a single icon, but a set of
icons ...
Comment 2 Havoc Pennington 2003-05-17 22:54:53 UTC 
Why not make the spinner just a single animated gif?
Comment 3 Marco Pesenti Gritti 2003-05-18 09:58:18 UTC 
In general people complain about gif patent issues and low quality.

I tried to convert two nautilus spinner to animated gifs:

http://mpgritti.oltrelinux.com/spinner.gif
http://mpgritti.oltrelinux.com/spinner2.gif

The default one (spinner.gif) doesnt appear to lose any quality, while
the spinner of the gnome theme gets totally ugly.

If I'm not mistake the spinner theme can be set only as hidden gconf
key now, so maybe it would be ok to move nautilus default spinner in
icon themes and live with quality issues until gtk has a better format
for animations.
But I really need to talk with nautilus developers about it.
Comment 4 spark 2003-05-18 11:54:50 UTC 
How about MNG (animated PNG)?

http://www.libpng.org/pub/mng/
Comment 5 Marco Pesenti Gritti 2003-05-18 16:02:18 UTC 
Gtk does not support mng
Comment 6 Havoc Pennington 2003-05-18 17:08:28 UTC 
The GIF patents are expired, there's no patent issue.

I guess the quality issue is from the 256-colors-per-frame limitation?
Really doesn't seem like that gnome spinner has so many colors...
but it's true that's a limitation.

MNG is the most overengineered thing on earth, sadly, and libmng's 
API is broken...
Comment 7 Marco Pesenti Gritti 2003-05-30 15:28:37 UTC 
Fixed in cvs. Now we use an icon from gnome-icon-theme. (With the grid
thing Alex suggested).