After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 111145 - Pan crashes when reading .newsrc file
Pan crashes when reading .newsrc file
Status: RESOLVED FIXED
Product: Pan
Classification: Other
Component: general
pre-0.14.0 betas
Other FreeBSD
: Normal critical
: 0.14.0
Assigned To: Charles Kerr
Pan QA Team
Depends on:
Blocks:
 
 
Reported: 2003-04-19 11:46 UTC by Pav Lucistnik
Modified: 2006-06-18 05:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Pav Lucistnik 2003-04-19 11:46:52 UTC 
I can reproduce SEGFAULT crash in server_is_valid(). It's caused by
groups_get_subscribed() function in base/group.c, where

Server * server;

is declared and then later

if (server != NULL)
    server_save_grouplist_if_dirty (server, NULL);

server have value 0x3 here, which causes crash in 

g_return_val_if_fail (is_nonempty_string (server->name), FALSE);

in server_is_valid() in base/server.c.

This only happens when I'm compiling Pan with CFLAGS -march=pentiumpro, it
does not happen when I omit -march switch. This haven't happened on
5.0-RELEASE (gcc 3.2.1), it does on -CURRENT with gcc 3.2.2. I'll check
with FreeBSD people in case it's compiler bug.

Fix: declare server as NULL in groups_get_subscribed() at group.c on line 209:

         Group ** changed;
-        Server * server;
+        Server * server = NULL;
         const ServerGroupsType type =
SERVER_GROUPS_SUBSCRIBED|SERVER_GROUPS_UNSUBSCRIBED;