GNOME Bugzilla – Bug 109224
Double clicking on a bookmark should open in a new window/tab based on the user pref.
Last modified: 2004-12-22 21:47:04 UTC
Double clicking on a bookmark should open in a new window/tab based on the user pref. The current behavior of opening the bookmark in a currently existing window is bad for a few reasons: 1. since the bme isn't transient to any window, its not clear which windows content it will clobber. 2. If you have no open browser window, double clicking does nothing. and for those who may complain, they can always drag and drop bookmarks from the editor to an existing window.
I'm not convinced about this. 2 should be fixed ... About 1. In the case you opened the bme from a window it should be clear that urls will open there. If you have closed that window, we could be smart enough to use the window the user used last time (we need something like this for other things too ...). I like the current behavior because most times I have just a window open and I open my bookmark one after the other there. I think this is a very common usage path. I guess I'll just mention that Phoenix has this behavior too ;)
I guess I look at like this: Whats more annoying opening a new window/tab (based on pref), or clobbering the page you were looking at that you wanted to keep open?
If it's implemented well I dont think there will be many cases where you will accidentally "overwrite" the page. Also there is an Undo feature ;) (Back).
The window choose code was borked btw ... now it should at least work better.
well the issue for me is that i always keep the bookmarks window open, so i'm never quite sure what will happen when i double click (which window it will open in) so i never double click and have to use context menus instead.
Can we pretty please change this behavior for 1.0? Especially now that we have a bookmarks menu for those that would want to open in the same window? The current behavior slows me down alot, since I need to context click to open bookmarks so that they don't kill what I'm already looking at.PRETTY PLEASE, I'm beggin here?
We can make a call for 1.0 ;)
Maybe this should be discussed on the list
Reinouts, do you have an opinion about this ?
This is a difficult one. We have to answer the question whether activating a bookmark from the bme is more like: a) opening a link (= it opens in the same window); b) opening a URL launcher from the desktop (= a new window opens)? My feeling (no hard evidence) about this is that opening a bookmark from the Bookmarks menu is more like a), and that opening one from the bme is more like b). Opinions?
Yeah I think it make sense. The other thing is history behavior. Should it be changed too ?
History behaviour should be as analogous to Bookmarks as possible. Or are there good reasons to handle history entries otherwise?
Not sure. Maybe the interaction with history is a bit different. You open bookmarks because you want to go to MPT blog. This is analogous to when you open the file manager to find your pdf about usability. In both case you click on the "document" and get it in a separate window. In history you dont know exactly what you are looking for often. You know you visited a certain site and you would like to find it again. You have often (at least me) to do several tries and having all the tries in a separate window could be annoying. Basically history is in the middle between browse a multiple links document and open a document. You have not given the item you are searching a name ... I tend to think like "Open a bookmark", "Browse the history". Just brain dumping, not really trying to make a point.
Dave, do you plan to do a patch for this ? Any opinion on history ?
Created attachment 18757 [details] [review] patch for bme and hst
I think opening history in a new window/tab is probably the most sane thing for 1.0 as well. The unpredictability as to what window/tab will have its data destroyed really is just bad. Perhaps we need to rethink the history design post 1.0.
The patch looks good but ... in the case of always open in tabs, you still have the confusion.
> in the case of always open in tabs, you still have the confusion. I really have no good suggestions here since I think always in tabs is a poorly defined pref. :/ ok to commit?
Yeah please commit. Thanks. Tabs are a pain ... I wonder if it would be a good idea to default to use a tab on middle click and make the Open in tabs always pref really do so (for popups and links too). At least it would be consistent. As it's now, it's just a mess.
commited. see my comments to the mailing list for the other issues