After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 108333 - gcalctool's key nav is broken
gcalctool's key nav is broken
Status: RESOLVED FIXED
Product: gnome-calculator
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rich Burridge
Rich Burridge
Depends on:
Blocks:
 
 
Reported: 2003-03-13 18:51 UTC by Glynn Foster
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.65 KB, patch)
2003-03-14 07:06 UTC, Dennis Cranston
none Details | Review
Proposed patch (1.65 KB, patch)
2003-03-14 07:06 UTC, Dennis Cranston
none Details | Review
Proposed patch (1.65 KB, patch)
2003-03-14 07:07 UTC, Dennis Cranston
none Details | Review

Description Glynn Foster 2003-03-13 18:51:45 UTC
for the menu style buttons, they only seem to activate on the second space
- it doesn't seem to bring up the menu either.
Comment 1 Dennis Cranston 2003-03-14 07:06:50 UTC
Created attachment 15008 [details] [review]
Proposed patch
Comment 2 Dennis Cranston 2003-03-14 07:06:50 UTC
Created attachment 15009 [details] [review]
Proposed patch
Comment 3 Dennis Cranston 2003-03-14 07:07:56 UTC
Created attachment 15010 [details] [review]
Proposed patch
Comment 4 Dennis Cranston 2003-03-14 07:11:28 UTC
Wow!  Why did bugzilla creat three proposed patches?   Well, they are
all the same patch.   

This patch connects a callback function to the key-press-event of the
menu buttons.
Comment 5 Dennis Cranston 2003-03-14 07:34:51 UTC
Hi Rich,

My proposed patch only implements a fix for pressing the space bar on
a menu button.  You will need to add code to handle the accelerators
such as 'S', 'A', etc.  You can put the code into the
menu_button_key_press_cb() function.

Good night,
Dennis
Comment 6 Rich Burridge 2003-03-14 21:24:15 UTC
Hi Dennis. Thanks! I'm just looking at this patch
now. What did you mean by "You will need to add code 
to handle the accelerators such as 'S', 'A', etc.".
These seem to work just fine. In other words, I
can type "A9" to set the accuracy to 9 numeric places
still, with just this patch applied.

One thing I have noticed is that the menu comes up
where the mouse pointer is. I think it would prolly
be better to have it coming up rooted on the button that's
currently got the focus. I'm just investigating how to
do that.
Comment 7 Rich Burridge 2003-03-14 22:58:25 UTC
Owen Taylor helped me with the adjustment to show
the menu over the button that has focus (rather than
where the mouse pointer is currently located).
Patch adjusted accordingly. Fixed in v4.2.69.