After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107623 - patch for x11 on cygwin
patch for x11 on cygwin
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.2.x
Other Windows
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2003-03-05 04:56 UTC by Masahiro Sakai
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
patch for compiling gtk+ for x11 on Cygwin (2.03 KB, patch)
2003-03-05 04:58 UTC, Masahiro Sakai 		none Details | Review

Description Masahiro Sakai 2003-03-05 04:56:51 UTC 
Here is a patch for compiling gtk+ for x11 on Cygwin.

Changes:
* configure.in: append $x_libs to GTK_EXTRA_LIBS when gdktarget is x11.
  Because gtkplug/gtksocket depend on libX11 directly.
* gdk/x11/gdkdrawable-x11.c (gdk_x11_draw_image): don't call XPutImage()
  unless USE_SHM is defined.
* gtk/queryimmodules.c: generalize SOEXT to use G_MODULE_SUFFIX rather
  than hardcoded .so/.dll.
Comment 1 Masahiro Sakai 2003-03-05 04:58:52 UTC 
Created attachment 14783 [details] [review]
patch for compiling gtk+ for x11 on Cygwin
Comment 2 Owen Taylor 2003-03-07 17:36:20 UTC 
Reassigning, since the win32 component is basically 
for the win32 backend.

 - First change needs to be done a little differently,
   because it's going to result in the .pc file 
   having the X11 libraries twice.

 - Change 2 looks right (but done somewhat differently..
   no need for the g_error(), just don't even include
   the if () if no SHM.)

 - The third change needs the USE_LA_MODULES magic
   from Pango's configure.in and pango/querymodules.c
Comment 3 Owen Taylor 2003-08-15 17:00:07 UTC 
Fri Aug 15 12:34:04 2003  Owen Taylor  <otaylor@redhat.com>
 
        Fixes for X/Cygwin builds of GTK+ (#107623, Masahiro Sakai):
 
        * configure.in (GDK_DEP_LIBS_FOR_X): Make sure that
        we link libgtk against X explicitely, since we
        make GTK+ calls for plug/socket.
 
        * gtk/queryimmodules.c: Use USE_LA_MODULES and
        G_MODULE_SUFFIX here.
 
        * gdk/x11/gdkdrawable-x11.c (gdk_x11_draw_image): Protect
        XShmPutImage with #ifdef USE_SHM.