After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 107528 - Menu keynav is backwards in RTL env
Menu keynav is backwards in RTL env
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
AP3
: 113976 (view as bug list)
Depends on:
Blocks: 76219
 
 
Reported: 2003-03-04 05:44 UTC by Noah Levitt
Modified: 2011-02-04 16:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
patch (1.12 KB, patch)
2003-11-16 23:15 UTC, Matthias Clasen
none Details | Review

Description Noah Levitt 2003-03-04 05:44:21 UTC
In RTL, keynav is backwards. <left> moves right, <right> moves left, etc.
Should be reversed.
Comment 1 Calum Benson 2003-04-03 14:26:05 UTC
Updating status_whiteboard field to reflect A11Y team's assessment 
of accessibility impact.
Comment 2 Owen Taylor 2003-05-20 18:00:24 UTC
Not really sure how is best to do this ... maybe 
just install the key bindings backwards for the
menus if gtk_widget_get_default_direction() is 
RTL. 

This won't handle change-on-the-fly of widget direction,
but practically speaking, that's not going to happen
in real uses, just in testgtk.

The "clean" way to do it would probably to allow 
separate RTL and LTR binding sets to be installed
for a GtkWidget class - extend:;

GtkBindingSet*  gtk_binding_set_by_class(gpointer        object_class);

to take a GtkTextDirection parameter. Shouldn't be
that hard to implement, but seems like a bit of
overkill.

Or, going in the unclean direction, you could simply
make GtkMenu interpret GTK_MENU_DIR_PARENT and 
GTK_MENU_DIR_CHILD backwards in RTL mode, but that
seems like a real mess to me.
Comment 3 Owen Taylor 2003-05-29 15:43:26 UTC
*** Bug 113976 has been marked as a duplicate of this bug. ***
Comment 4 Jody Goldberg 2003-05-29 15:52:28 UTC
Changing on the fly will happen in real world usages.
I need to support per worksheet (somewhat like notebook a tab)
directionality in gnumeric.
Comment 5 Owen Taylor 2003-05-29 16:16:08 UTC
I don't think it's sensible to flip the auxilliary UI elements -
it's going to be very strange of the auxilliary UI elements
don't follow the message language.
Comment 6 Calum Benson 2003-08-07 16:09:43 UTC
Apologies for spam... marking as GNOMEVER2.3 so it appears on the official GNOME
bug list :)
Comment 7 Matthias Clasen 2003-11-16 23:15:02 UTC
Here is the "real mess" approach. Note the extra hack of also flipping
prev and next for menubars. Works nicely.
Comment 8 Matthias Clasen 2003-11-16 23:15:46 UTC
Created attachment 21510 [details] [review]
patch