After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 106942 - pango_font_description_hash vs. pango_font_description_equal
pango_font_description_hash vs. pango_font_description_equal
Status: RESOLVED FIXED
Product: pango
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Owen Taylor
Owen Taylor
Depends on:
Blocks:
 
 
Reported: 2003-02-24 17:15 UTC by Morten Welinder
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: 2.1/2.2


Description Morten Welinder 2003-02-24 17:15:44 UTC 
pango_font_description_hash is case sensitive.
pango_font_description_equal is case INsensitive.  (Why?)

That's not a valid combination for making a hash table.  (Maybe
pango_font_description_set_family should do the lower-casing if it is
really needed.)
Comment 1 Owen Taylor 2003-04-30 20:54:58 UTC 
I've just made the hash function case insensitive; I
want to preserve the ability to pass strings cased
for better legibility through a font description; and
while would might be possible to cache a lower-cased version
of the name in the font description, I'm guessing that
the performance win would be small... ASCII lowercasing
is fast. (And that's all that we are doing.)

Wed Apr 30 16:46:52 2003  Owen Taylor  <otaylor@redhat.com>
 
        * pango/fonts.c (pango_font_description_hash): Hash
        case insensitively (#106942, Morten Welinder)