GNOME Bugzilla – Bug 106701
Please use ngettext for handling plurals in libgtop
Last modified: 2004-12-22 21:47:04 UTC
#: lib/read.c:75 #, c-format msgid "read %d bytes" #: lib/read_data.c:66 #, c-format msgid "read data %d bytes" #: lib/write.c:48 #, c-format msgid "write %d bytes" As mentioned in http://developer.gnome.org/doc/tutorials/gnome-i18n/developer.html#plurals, this way of handling plurals is broken for many locales. A way to solve this is by using ngettext instead as mentioned in that document. A simple code example of code using ngettext: g_printf (ngettext ("Found %d file.", "Found %d files.", nbr_of_files), nbr_of_files);
Hmm. We need to branch this package at some point. That is going to be hard I guess. Or we could just make a stable release. and then start doing 2.3.x releases? But this will have to be decided ASAP.
Good point. Should probably be brought up on desktop-devel-list.
Created attachment 20110 [details] [review] Proposed patch. Untested, compiled fine.
Created attachment 20157 [details] [review] Proposed patch, removed inner gettext calls.
Can we have this issue revisited now?
Applied to gnome-2-4 and HEAD 2003-10-20 Bastien Nocera <hadess@hadess.net> * lib/read.c: (glibtop_read_l): * lib/read_data.c: (glibtop_read_data_l): * lib/write.c: (glibtop_write_l): apply patch for ngettext support by Christian Neumair <chris@gnome-de.org>
I think you're safe marking this as FIXED, since the "official" target for ngettext support is Gnome 2.6. This means that it's too late for Gnome 2.4. I suggest removing GNOMEVER2.3 keyword and marking this as either fixed, _or_ marking it as WONTFIX, so it's clear what's the goal. Unless someone thinks otherwise?