GNOME Bugzilla – Bug 105977
dialogs need help buttons
Last modified: 2004-12-22 21:47:04 UTC
The following dialogs need help buttons. I think we should probably add them now, even if the documentation is not complete (doesn't exist?). That way when we do have docs in the future, we won't need to make ui changes. Anyway here's the list: 1. History 2. Bookmarks 3. PDM 4. Toolbar editor 5. Preferences 6. Print The help button should be in the lower left corner of each dialog.
Created attachment 15209 [details] [review] patch to add in help support for Epiphany
Created attachment 15210 [details] omf-install dir, help dir, and other files required for help support
I've added 1. help manual support to Epiphany (code added in the handler) 2. added in a help/ directory with the necessary makefile 3. Written a basic xml file which will be extended, this is the help manual. It is in help/C/epiphany.xml 4. Done the necessary scrollkeeper integration, which means an omf-install/ directory and some other make files here and there. 5. Created and integrated a screenshot of the app in the help manual. 6. Done Configure.in changes and Makefile changes at the top level All this gets help support in, so when one clicks on help->contents, yelp opens with the help manual. This will be exctended to include context sensitive help, bookmark tab help etc. This is the first step of setting up the required infrastructure. There are two attachments: 1. Patch file for top level Makefile.am, configure.in, and src/window-commands.c (callback edited). 2. Tarball containing the extra files and directories that need to be added. I hope these files are sufficient. If they are integrated and cause build problems or other problems, will resolve them as soon as possible :)
15209 Looks good. Please remove the FIXME too. I have no way to uncompress the tarball but I'm sure I can trust you on that ;) At worst if there are problems we can fix them later. So please commit this. Thank you very very much.
patched. Not closed the bug because help buttons still need to be added, and the help manual needs updating.
Created attachment 15296 [details] [review] adds help button to prefs dialog and place holders in the help file
marco did you look at this patch for pref dialog help button? (just a friendly reminder:) )
It looks good. Sorry, I didnt notice this in my mailbox :/ Please commit, thank you.
patanjali: Can you commit this, otherwise i can do it for you.
Commited .. more patches to follow.
Patanjali, I'm sorry to not have warned you about the upcoming release, I'll do it next time I promise :) I think it would be good to coordinate the documentation work so that you dont do work on things that could have ui changes later. Maybe we should discuss it before you start writing contents.
Patanjali: I just added a help menu to the bookmarks editor, so if you have time adding help there would rock!!!
Created attachment 15716 [details] [review] adds help buttons to bookmark properties and new bookmark. Still need to be hooked up. Ok to commit?
(15716 have been committed) Release is going to be near 5 May, would be nice to have this too fixed ;)
I think we have most of them. Remaining ones are print, personal_data and find. Find can probably get away without a help button (there should really be a stock dialog for this one anyway, blah). Adding one to the print dialog would be nice too, although I'd move print preview into the file menu first before doing this. I have no way of patching and testing the pdm since it always crashes on me.
I'd say adding it to the pdm could do for 1.0.
Help button in pdm is now implemented.
I'm marking this fixed. Barring a stock find dialog, or using the libgnomeprintui print dialog i don't think we can reasonably add help buttons to these dialogs in their current state and still maintain asthetics.
Created attachment 19055 [details] [review] More documentation - about epiphany bookmarks system
pantajali, your docs look ok. Its not necessary to say the "Epiphany Toolbar" simply using "toolbar" is acceptable, so please remove the "Epiphany"s and commit to cvs.