GNOME Bugzilla – Bug 105231
RFE: scaled background image: cropping vs. empty borders
Last modified: 2013-05-13 12:16:45 UTC
Package: control-center Severity: enhancement Version: 2.1.7 Synopsis: scaled of two; inside outside Bugzilla-Product: control-center Bugzilla-Component: background Description: atm, scaled one fit image to screen border, inside. I suggest to provide outside scaled one; i.e. when image is 400x400 and screen is 800x600, inside scaled; image grow to 600x600 to fit 600 of height. outside scaled; grow to 800x800 to fit 800 of weight. well, there must be a good glossary for this matter, rather than inside/outside. ------- Bug moved to this database by unknown@bugzilla.gnome.org 2003-02-04 15:16 ------- Reassigning to the default owner of the component, control-center-maint@bugzilla.gnome.org.
So instead of having two blank areas on either side of the image, you'll be missing the top 100 and bottom 100 pixels. I prefer having blank areas on two sides of a background, but I'm not sure there's a good argument for one choice versus another.
I'm not arguing for which is better; than I'm asking both of them supported. :)
Isn't it just as easy to scale the picture in a image manipulation program first if you have odd sized backgrounds?
Kjartan: are you saying that options of 'Scaled' and 'Stretched' are unnecessary?
Yeah. No I'm kidding. It's what days of bugzilla work does to you.
I don't understand what this bug wants. If you don't want the bars around the border, choose "Fill Screen". If you don't care and want to maintain the aspect ratio of the image, choose "Scale".
Patches to add "Zoom" mode to backgrounds. This mode enlarges the image so as to cover desktop while maintaining the aspect ratio. I.e. either chop top and bottom or left and right edges per previous comments. There are four patches to control-center, nautilus, eel and gnome-user-docs plus a new stock image. I've primarily did this for a 16:10 widescreen laptop where stretched 4:3 images look bad, but it's also useful for tall images on normal monitors.
Created attachment 34774 [details] [review] bgzoom-controlcenter.patch Patch to control-center. Addes WPTYPE_ZOOM.
Created attachment 34775 [details] [review] bgzoom-eel.patch Patch to eel. Adds EEL_BACKGROUND_ZOOM and two functions eel_gdk_scale_to_min_factor() and eel_gdk_pixbuf_scale_to_min() for scaling an image to minimum size.
Created attachment 34776 [details] [review] bgzoom-nautilus.patch Patch to nautilus. Same changes for libbackground from control-center patch and for EEL_BACKGROUND_ZOOM from eel.
Created attachment 34777 [details] [review] bgzoom-gnome2userdocs.patch Add help for Zoomed mode. Also corrects Tiled mode and Fill Screen descriptions, and a touch of reformatting as a suggestion.
Created attachment 34778 [details] stock_wallpaper-zoom.png New stock image for Zoom mode. Basically I wanted to show that the image would extend beyond the boundary of the window. Tricky in a 16x16 icon but this looks good.
Created attachment 34779 [details] [review] bgzoom-eel.patch Uploaded wrong eel patch. This one has corrected declaration for eel_gdk_pixbuf_scale_to_min() in eel-gdk-pixbuf-extensions.h.
Overall, the background capplet patch looks ok. However, I don't like the idea of using the term "Zoom" for this. It's very non-descript and I think we can do better. Unfortunately, while I would like to put this feature into 2.10, I can't think of a better term to call it right now, which means that I think we should wait until 2.12 to put it in. Thanks for doing the work though. Hopefully we can come up with better terminology for it soon. This also makes me realize how much I hate that one aspect of the UI on my new TV. It has "Normal", "Full", "Zoom" and "Wide Zoom" screen modes. Aside from normal and full being obvious 4:3 and filling the screen, I have no bloody idea what the two zoom modes *actually* do. I always pause the DVD and cycle through comparing proper dimensions for squares and circles to make things look right, and leave it on the best one. I'd rather make it easier for the user to decide what to use. It's not exactly brilliant right now, but I think for most images on most screens, the current stuff is sufficiently usable. Anyway, enough ranting for now.
"Scaled (touch inside)" and "Scaled (touch outside)". I just filed a bug on this myself because I'm a fucking dolt and didn't search with the right terms first.
I have been thinking about suitable name after Rodney's comments but the problem is the current "Fill screen" which is just stretched mode. It basically sounds the same as what this new mode provides and could cause confusion. We should perhaps rename it back to "Stretched" although unlikely due to current user recognition. Still prefer "Zoom" myself as it is very simple and descriptive, it does what is says. Perhaps "Zoom Fill" or "Scaled Zoom" at a push. (I personally dislike the enclosing of extra descriptions in brackets.) I'd really like to see this included for 2.12. Perhaps Rodney could add something to his blog for suggestions from other people reading on Planet Gnome? ;-)
*** Bug 302739 has been marked as a duplicate of this bug. ***
"Centred Zoomed"?
can't this patch be applied to gnome 2.11 so people will notice it and give it a better name? Or are we already in string freeze?
Wow, this bug is still open!? It seems the only thing stopping it from going any further is the naming scheme. I say drop "Fill Screen" for "Stretched", and use "Fill Screen" and "Auto Size" for the new types. So: "Centred" 1x centred "Tiled" 1x tiled "Fill Screen" scaled outside "Auto Size" scaled inside "Stretched" axis independent resize
The current names will not change to mean something other than what they already do. And, 2.11 is already in Feature and UI freeze. So, no, I will not be putting this into 2.11.
Any chance of getting this included for 2.14 this time? Next name try is "Cropped Zoom" or just "Cropped" but I still prefer plain old "Zoom" as being a far clearer description. I'll raise a seperate bug by the end of next week to at least get the required functionality into the eel library.
Created attachment 55529 [details] [review] bgzoom-controlcenter-cvs-20051202.patch Updated control-center patch which applies to both CVS HEAD and Gnome 2.12.
*** Bug 318201 has been marked as a duplicate of this bug. ***
Now is probably the right period of the cycle to get the patch accepted
"Fit Inside" "Fit Outside"?
the eel patch has been commited, that's the right time to get that bug fixed if you want to fix it for this cycle, freeze is next week
Yeah, I'll have some time to work on it this weekend. I've been overly busy with other things, so unfortunately haven't had time. I'm making time this weekend though, due to the freeze. If the EEL patch is in, can someone clean up the nautilus patch to not include the libbackground stuff, and get the libnautilus-private bits committed? Also notify that the nautilus hackers should wait to release, until the libbackground stuff gets committed to control center.
Created attachment 57245 [details] [review] bgzoom-nautilus-cvs-20060112.patch The Nautilus patch without the libbackground bits as requested.
OK. Can you please get the Nautilus patch approved and committed asap? I'll get the control center bits committed, along with some other work I'm doing. The patch works ok for me. Oh, and the docs stuff needs to be handled in that module as well. Thanks.
I've mailed the nautilus list about it, I'm pretty confident it'll be commited before next tarball, but maybe not before monday (alex is only around during the week usually)
I'll commit the nautilus patch when the background bits have landed.
Created attachment 57338 [details] [review] bgzoom-gnomeicontheme.patch-cvs-20060114 Just in case this is overlooked, this is a one liner Makefile patch for gnome-icon-theme to install the icon stock_wallpaper-zoom.png which should itself be dropped in the 16x16/stock/image/ directory.
Martin: The libbackground part is committed now. The UI part will be committed soon enough. Please commit the nautilus parts. Thanks.
Comment on attachment 57245 [details] [review] bgzoom-nautilus-cvs-20060112.patch It's in.
OK. I've committed the UI additon now as well. Will send mail to the docs/i18n lists for this, as soon as I fix a few other things in the capplet as well. Leaving this open until the docs are fixed also.
Created attachment 79571 [details] [review] backgroundhelp-gnome2userdocs.patch Whilst the zoom mode finally got integrated last year, the user docs are still woefully wrong since year dot so I've updating the user docs patch for the patch party today on #control-center. The descriptions are wrong for three out of the four currently documented modes. I've corrected them with improved grammer. Also people understand the phrase "aspect ratio" better than "relative dimensions" due to widescreen TV and DVD usage. (With the great purging of icons last year, the stock_wallpaper-zoom.png was no longer required so I've obsoleted it.)
Moving to the docs component. Hopefully the docs team will see it and get it in. :)
FWIW, I didn't see anything wrong with 'maintains the relative dimensions', and I'm a little unconvinced that 'aspect ratio' is a widely-understood term among general computer users yet. If it were, I'd expect Photoshop, GIMP, Office etc. to use it in their rescaling dialogs, rather than the terminology like "constrain proportions" that most of them still seem to use.
This patch is outdated, the design moved on a couple of times since then, so closing this bug as OBSOLETE.