After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 104986 - memleak fix
memleak fix
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: general
2.1.x
Other other
: Immediate blocker
: future
Assigned To: Anders Carlsson
Anders Carlsson
Depends on:
Blocks:
 
 
Reported: 2003-02-01 14:51 UTC by Havoc Pennington
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
things look better with this patch (45.46 KB, patch)
2003-02-03 21:15 UTC, Christophe Fergeau 		none Details | Review
2nd try.... (527 bytes, patch)
2003-02-03 21:21 UTC, Christophe Fergeau 		none Details | Review

Description Havoc Pennington 2003-02-01 14:51:52 UTC 
See https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=83282
Comment 1 Anders Carlsson 2003-02-01 15:14:37 UTC 
Fixed in CVS
Comment 2 Dennis Cranston 2003-02-03 20:33:06 UTC 
YIPES!!!  Something is seriously wrong with this patch and it should
be reverted!

I have a redhat 8.0 system with gnome 2.2 built via
vicious-build-scripts.   With the patch applied gnome-session,
gnome-panel, and nautilus all hang.  I am not able to log into a gnome
2.2 at all.  After reverting the patch, the problem was resolved.
Comment 3 Christophe Fergeau 2003-02-03 21:15:03 UTC 
Created attachment 14073 [details] [review]
things look better with this patch
Comment 4 Christophe Fergeau 2003-02-03 21:15:57 UTC 
It looks like a g_free was left where it shouldn't when the patch was
committed to cvs
Comment 5 Christophe Fergeau 2003-02-03 21:19:55 UTC 
Hmm, forget the previous patch :)
I should be careful with unclean trees
Comment 6 Christophe Fergeau 2003-02-03 21:21:26 UTC 
Created attachment 14074 [details] [review]
2nd try....
Comment 7 Sri Ramkrishna 2003-02-04 01:08:42 UTC 
Anders has reverted the patch.

sri
Comment 8 Kjartan Maraas 2003-02-04 08:30:18 UTC 
I think the problem here was the double free, not the patch itself.
It's surely a small leak, but if there's no other problem with it than
that please apply the fix again, minus the second g_free(tmp)?
Comment 9 Kjartan Maraas 2003-05-01 16:25:49 UTC 
Reapplying to both branches.