GNOME Bugzilla – Bug 104287
[PATCH] HIG improvements for the "Insert ASCII Value" dialog
Last modified: 2004-12-22 21:47:04 UTC
The "Insert ASCII Value" dialog is not HIG compliant. The attached patch makes the following improvements. 1. Makes the window a true dialog. This means no minimize, maximize, or resize buttons in the window's frame. Also, the window is a transient of the main window. 2. Adds a mnemonic character for the text entry. 3. Replaces "ok" button with an "insert" button. 4. Fixes up the padding. As a result, the buttons are all the same size, and the outer edges of the various widgets in the dialog line up.
Created attachment 13793 [details] [review] The patch file
Created attachment 13794 [details] A quick screenshot.
This looks great. Thanks Dennis! Calum, if it meets with your approval, I'll commit it when I get to work later this morning.
Note that Calum also submitted bug #104242 on this issue, so I'm just getting clarification from him that your fix is okay, and I can kill two birds (um, bugs) with one stone (um, patch). (Where's the "See Also: field in bugzilla)? Grrr.
Looks good from the screenshot. I think Cancel should probably be beside Insert rather than aligned with the opposite edge, though... especially if we want to give the "Add Function" and related dialogs the same treatment, which should probably have a Help button where the Cancel button is in this screenie.
Created attachment 13808 [details] [review] New patch with cancel button placed according to Calum's comments.
Created attachment 13809 [details] New screenshot.
Looks good. Is Insert the default button in this dialog? If not I'd probably do that as well.
*** Bug 104242 has been marked as a duplicate of this bug. ***
Patch applied (modulo my anal coding style - no tabs, 80 character line limit, always use braces even on a one line if statement). Fixed in v4.2.38 of gcalctool. Thanks again Dennis!
The insert button was not set as the default. This should be fixed, so I am reopening the bug report. I will attach one more patch. The patch fixes two remaining bugs: 1. The insert button should be the default. 2. The dialog should not be resizable.
Created attachment 13816 [details] [review] One last patch file.
I should have never called that last patch the "last" one. Anyhow, I realized there needs to be one more fix. This patch includes the same fixes as the previous plus it hooks up the ESC key for canceling the dialog. Thanks.
Created attachment 13818 [details] [review] Adds ESC key handling.
Thanks for the further work on this. I've just checked in your changes, so hopefully everything is fixed up now. Fixed in v4.2.39.