After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 103813 - More impossible weather combination to be removed
More impossible weather combination to be removed
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: gweather
git master
Other All
: High minor
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2003-01-18 14:37 UTC by Abel Cheung
Modified: 2004-12-22 21:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to remove impossible weather conditions (21.27 KB, patch)
2003-01-18 14:38 UTC, Abel Cheung 		none Details | Review

Description Abel Cheung 2003-01-18 14:37:45 UTC 
http://www.crh.noaa.gov/arx/wx.tbl.html lists all
combination of weather status that can be reported.
The attached patch only removes strings but don't add
any, so hopefully this won't be problematic with
i18n people.

But gweather needs to improve (e.g. handling multiple
weather conditions) after GNOME 2.2 is out, though.

Patch attached.
Comment 1 Abel Cheung 2003-01-18 14:38:23 UTC 
Created attachment 13662 [details] [review]
Patch to remove impossible weather conditions
Comment 2 Abel Cheung 2003-02-21 05:51:52 UTC 
OK, just found out gnome-applets 2.3 is rewriting this part
of code. So the patch only applies to 2.2.x.
Comment 3 Christian Neumair 2003-07-16 17:16:36 UTC 
Deaddog: Thanks for your patch! Great job.
Kevin: Could you please merge those fixes with HEAD?
By that, you save translators a lot of redundant work.

regs,
 Chris
Comment 4 Kevin Vandersloot 2003-07-16 17:45:00 UTC 
Yah, the patch looks good to me. Please commit Deaddog. Thanks a lot!
Comment 5 Abel Cheung 2003-07-16 20:24:13 UTC 
Thanks for permission, it is committed to both head and gnome-2-2
branch (I don't know if it's dead code or not).

Btw, if the old codebase will still be used, probably we can borrow
some part of code from phpweather (especially METAR code parsing).