GNOME Bugzilla – Bug 102382
Remove unnecessary markup from glade messages in epiphany
Last modified: 2011-09-04 21:43:23 UTC
#: data/glade/epiphany.glade.h:3 msgid "<b>File:</b>" #: data/glade/epiphany.glade.h:4 msgid "<b>Find text in the document:</b>" #: data/glade/epiphany.glade.h:5 msgid "<b>Location:</b>" #: data/glade/epiphany.glade.h:6 msgid "<b>Status:</b>" #: data/glade/epiphany.glade.h:7 msgid "<b>Time Elapsed:</b>" #: data/glade/epiphany.glade.h:8 msgid "<b>Time Remaining:</b>" #: data/glade/epiphany.glade.h:9 msgid "" "<span weight=\"bold\" size=\"larger\">What do you want to do with this " "file?\n" "</span>\n" "It's not possible to view this file type directly in the browser:" #: data/glade/prefs-dialog.glade.h:4 msgid "<b>Caches</b>" #: data/glade/prefs-dialog.glade.h:5 data/glade/print.glade.h:3 msgid "<b>Colors</b>" #: data/glade/prefs-dialog.glade.h:6 msgid "<b>Fonts</b>" #: data/glade/prefs-dialog.glade.h:7 msgid "<b>Home page</b>" #: data/glade/prefs-dialog.glade.h:8 msgid "<b>Language</b>" #: data/glade/prefs-dialog.glade.h:9 msgid "<b>Links</b>" #: data/glade/prefs-dialog.glade.h:10 msgid "<b>On New Page</b>" #: data/glade/prefs-dialog.glade.h:11 msgid "<b>Spinner</b>" #: data/glade/prefs-dialog.glade.h:12 msgid "<b>Tabs</b>" #: data/glade/print.glade.h:4 msgid "<b>Footers</b>" #: data/glade/print.glade.h:5 msgid "<b>Headers</b>" #: data/glade/print.glade.h:6 msgid "<b>Margins (inches)</b>" #: data/glade/print.glade.h:7 msgid "<b>Orientation</b>" #: data/glade/print.glade.h:8 msgid "<b>Pages range</b>" #: data/glade/print.glade.h:9 msgid "<b>Printer</b>" #: data/glade/print.glade.h:10 msgid "<b>Size</b>" #: data/glade/toolbar-editor.glade.h:1 msgid "<b>Cu_rrent Controls</b>" #: data/glade/toolbar-editor.glade.h:2 msgid "<b>_Available Controls</b>" This use of markup inside messages marked for translation is totally unnecessary, and a problem for the translation process. For details, see the problem description in bug 96836. Since these are glade messages, I'll mark it dependant on the glade bug 97061 in the mean time.
This really depends on glade fixes
-> i18n
Mass reassigning of Epiphany bugs to epiphany-maint@b.g.o
Those files doesn't even exist anymore. I'm marking this as obsolete.
This is still relevant.
Then we must fix it, it's pretty old :). Where are this messages now?
You can grep for '<b>' in po/*.po, and notice data/glade/* references: #: ../data/glade/certificate-dialogs.glade.h:1 msgid "<b>Fingerprints</b>" Then see the original context: data/glade/certificate-dialogs.glade: <property name="label" translatable="yes"><b>Fingerprints</b></property>
So the glade3 bug is fixed now, but we still cannot use this since we have to keep using glade2 due to glade3 not being able to correctly read/write our files in GtkBuilder format.
Created attachment 154910 [details] [review] Remove markup in labels
There is still two bolds in epiphany.ui which are bound to a GtkRadioButton Which doesn't support attributes (see bug #591821). Note that my patch should be only applied after epiphany will have branched for 2.30 (string freeze currently).
Created attachment 178121 [details] [review] Updated patch Any chance of this getting fixed for gnome 3? Attached an updated patch.
Created attachment 184742 [details] [review] data/glade: remove markup from labels Use attributes instead of hardcoding the markup on the translatable string. Bug #102382
Review of attachment 184742 [details] [review]: You are just removing the use_underline markup. If they do nothing make a different patch removing all of them, and keep this patch just for the actually working markup.
Created attachment 194300 [details] [review] prefs-dialog: remove unused underline property Bug #102382
Created attachment 194301 [details] [review] data/glade: remove unneeded markup Use attributes instead of hardcoding the markup on the translatable string. Bug #102382
Glade introduced the usual noise. Won't bother removing it...
Review of attachment 194300 [details] [review]: r=me
Review of attachment 194301 [details] [review]: I liked this patch more when it didn't move everything around.
Ok, done! Too bad glade is so noisy. Attachment 194300 [details] pushed as 90455da - prefs-dialog: remove unused underline property Attachment 194301 [details] pushed as 46312f0 - data/glade: remove unneeded markup