NetworkManager-0.9.9.1-7880.05b5577815.fc20

List of Defects

Error: FORWARD_NULL (CWE-476): [#def1]
NetworkManager-0.9.9.1/cli/src/utils.c:663: var_compare_op: Comparing "group_fields" to null implies that "group_fields" might be null.
NetworkManager-0.9.9.1/cli/src/utils.c:702: var_deref_op: Dereferencing null pointer "group_fields".

Error: NULL_RETURNS (CWE-476): [#def2]
NetworkManager-0.9.9.1/cli/src/utils.c:797: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/cli/src/utils.c:797: var_assigned: Assigning: "row" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/cli/src/utils.c:799: dereference: Dereferencing a null pointer "row".

Error: DEADCODE (CWE-561): [#def3]
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1151: assignment: Assigning: "child_prop" = "0".
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1166: const: At condition "child_prop", the value of "child_prop" must be equal to 0.
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1166: dead_error_condition: The condition "child_prop" cannot be true.
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1166: dead_error_line: Execution cannot reach this expression "style_prop" inside statement "if (child_prop && !style_pr...".

Error: DEADCODE (CWE-561): [#def4]
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1152: assignment: Assigning: "style_prop" = "0".
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1168: const: At condition "style_prop", the value of "style_prop" must be equal to 0.
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1168: dead_error_condition: The condition "style_prop" cannot be true.
NetworkManager-0.9.9.1/docs/libnm-glib/libnm-glib-scan.c:1169: dead_error_line: Execution cannot reach this statement "*pos++ = 's';".

Error: DEADCODE (CWE-561): [#def5]
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1246: assignment: Assigning: "child_prop" = "0".
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1261: const: At condition "child_prop", the value of "child_prop" must be equal to 0.
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1261: dead_error_condition: The condition "child_prop" cannot be true.
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1261: dead_error_line: Execution cannot reach this expression "style_prop" inside statement "if (child_prop && !style_pr...".

Error: DEADCODE (CWE-561): [#def6]
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1247: assignment: Assigning: "style_prop" = "0".
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1263: const: At condition "style_prop", the value of "style_prop" must be equal to 0.
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1263: dead_error_condition: The condition "style_prop" cannot be true.
NetworkManager-0.9.9.1/docs/libnm-util/libnm-util-scan.c:1264: dead_error_line: Execution cannot reach this statement "*pos++ = 's';".

Error: RESOURCE_LEAK (CWE-772): [#def7]
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:69: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:69: var_assign: Assigning: "res" = handle returned from "open(path, flags, mode)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:69: overwrite_var: Overwriting handle "res" in "res = open(path, flags, mode)" leaks the handle.

Error: RESOURCE_LEAK (CWE-772): [#def8]
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:348: open_fn: Returning handle opened by function "open_nointr(char const *, int, mode_t)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:69:5: open_fn: Returning handle opened by function "open(char const *, int, ...)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:69:5: var_assign: Assigning: "res" = "open(path, flags, mode)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:71:3: return_handle: Returning opened handle "res".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:348: var_assign: Assigning: "fd" = handle returned from "open_nointr(gs_file_get_path_cached(file), 193, mode)".
NetworkManager-0.9.9.1/libgsystem/gsystem-file-utils.c:368: leaked_handle: Handle variable "fd" going out of scope leaks the handle.

Error: NULL_RETURNS (CWE-476): [#def9]
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:336: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:336: var_assigned: Assigning: "padded_buf" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:338: dereference: Dereferencing a pointer that might be null "padded_buf" when calling "memcpy(void * restrict, void const * restrict, size_t)".

Error: NULL_RETURNS (CWE-476): [#def10]
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:336: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:336: var_assigned: Assigning: "padded_buf" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/crypto_nss.c:340: dereference: Dereferencing a null pointer "padded_buf".

Error: RESOURCE_LEAK (CWE-772): [#def11]
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:494: alloc_fn: Storage is returned from allocation function "nm_ip4_address_dup(NMIP4Address *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1560:2: alloc_fn: Storage is returned from allocation function "nm_ip4_address_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1539:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1539:2: var_assign: Assigning: "address" = "g_malloc0(16UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1541:2: return_alloc: Returning allocated memory "address".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1560:2: var_assign: Assigning: "address" = "nm_ip4_address_new()".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1565:2: return_alloc: Returning allocated memory "address".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:494: var_assign: Assigning: "copy" = storage returned from "nm_ip4_address_dup(address)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:495: leaked_storage: Variable "copy" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def12]
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:647: alloc_fn: Storage is returned from allocation function "nm_ip4_route_dup(NMIP4Route *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1773:2: alloc_fn: Storage is returned from allocation function "nm_ip4_route_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1752:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1752:2: var_assign: Assigning: "route" = "g_malloc0(20UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1754:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1773:2: var_assign: Assigning: "route" = "nm_ip4_route_new()".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:1779:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:647: var_assign: Assigning: "copy" = storage returned from "nm_ip4_route_dup(route)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip4-config.c:648: leaked_storage: Variable "copy" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def13]
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:492: alloc_fn: Storage is returned from allocation function "nm_ip6_address_dup(NMIP6Address *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1344:2: alloc_fn: Storage is returned from allocation function "nm_ip6_address_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1323:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1323:2: var_assign: Assigning: "address" = "g_malloc0(40UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1325:2: return_alloc: Returning allocated memory "address".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1344:2: var_assign: Assigning: "address" = "nm_ip6_address_new()".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1349:2: return_alloc: Returning allocated memory "address".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:492: var_assign: Assigning: "copy" = storage returned from "nm_ip6_address_dup(address)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:493: leaked_storage: Variable "copy" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def14]
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:635: alloc_fn: Storage is returned from allocation function "nm_ip6_route_dup(NMIP6Route *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1561:2: alloc_fn: Storage is returned from allocation function "nm_ip6_route_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: var_assign: Assigning: "route" = "g_malloc0(44UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1542:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1561:2: var_assign: Assigning: "route" = "nm_ip6_route_new()".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1567:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:635: var_assign: Assigning: "copy" = storage returned from "nm_ip6_route_dup(route)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:636: leaked_storage: Variable "copy" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def15]
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:262: alloc_fn: Storage is returned from allocation function "priority_map_new_from_str(NMVlanPriorityMap, char const *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:191:4: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:191:4: var_assign: Assigning: "p" = "g_malloc0(8UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:201:2: return_alloc: Returning allocated memory "p".
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:262: var_assign: Assigning: "item" = storage returned from "priority_map_new_from_str(map, str)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-vlan.c:263: leaked_storage: Variable "item" going out of scope leaks the storage it points to.

Error: NULL_RETURNS (CWE-476): [#def16]
NetworkManager-0.9.9.1/libnm-util/nm-utils.c:2126: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/libnm-util/nm-utils.c:2126: var_assigned: Assigning: "result" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-utils.c:2129: dereference: Dereferencing a null pointer "result".

Error: UNREACHABLE (CWE-561): [#def17]
NetworkManager-0.9.9.1/src/NetworkManagerUtils.c:1145: unreachable: This code cannot be reached: "return "XXXXX";".

Error: USE_AFTER_FREE (CWE-825): [#def18]
NetworkManager-0.9.9.1/src/dhcp-manager/nm-dhcp-dhclient.c:562: freed_arg: "g_free(gpointer)" frees "leasefile".
NetworkManager-0.9.9.1/src/dhcp-manager/nm-dhcp-dhclient.c:565: pass_freed_arg: Passing freed pointer "leasefile" as an argument to function "_nm_log(char const *, char const *, guint64, guint32, char const *, ...)".

Error: RESOURCE_LEAK (CWE-772): [#def19]
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: alloc_fn: Storage is returned from allocation function "nm_ip6_route_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: var_assign: Assigning: "route" = "g_malloc0(44UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1542:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: var_assign: Assigning: "s_route" = storage returned from "nm_ip6_route_new()".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:547: leaked_storage: Variable "s_route" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def20]
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: alloc_fn: Storage is returned from allocation function "nm_ip6_route_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: var_assign: Assigning: "route" = "g_malloc0(44UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1542:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: var_assign: Assigning: "s_route" = storage returned from "nm_ip6_route_new()".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:551: leaked_storage: Variable "s_route" going out of scope leaks the storage it points to.

Error: RESOURCE_LEAK (CWE-772): [#def21]
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: alloc_fn: Storage is returned from allocation function "nm_ip6_route_new(void)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: alloc_fn: Storage is returned from allocation function "g_malloc0(gsize)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1540:2: var_assign: Assigning: "route" = "g_malloc0(44UL)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1542:2: return_alloc: Returning allocated memory "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:543: var_assign: Assigning: "s_route" = storage returned from "nm_ip6_route_new()".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:553: noescape: Resource "s_route" is not freed or pointed-to in function "nm_ip6_route_set_dest(NMIP6Route *, struct in6_addr const *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1657:36: noescape: "nm_ip6_route_set_dest(NMIP6Route *, struct in6_addr const *)" does not free or save its pointer parameter "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:554: noescape: Resource "s_route" is not freed or pointed-to in function "nm_ip6_route_set_prefix(NMIP6Route *, guint32)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1691:38: noescape: "nm_ip6_route_set_prefix(NMIP6Route *, guint32)" does not free or save its pointer parameter "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:557: noescape: Resource "s_route" is not freed or pointed-to in function "nm_ip6_route_set_metric(NMIP6Route *, guint32)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:1763:38: noescape: "nm_ip6_route_set_metric(NMIP6Route *, guint32)" does not free or save its pointer parameter "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:559: noescape: Resource "s_route" is not freed or pointed-to in function "nm_setting_ip6_config_add_route(NMSettingIP6Config *, NMIP6Route *)".
NetworkManager-0.9.9.1/libnm-util/nm-setting-ip6-config.c:620:46: noescape: "nm_setting_ip6_config_add_route(NMSettingIP6Config *, NMIP6Route *)" does not free or save its pointer parameter "route".
NetworkManager-0.9.9.1/src/nm-ip6-config.c:560: leaked_storage: Variable "s_route" going out of scope leaks the storage it points to.

Error: FORWARD_NULL (CWE-476): [#def22]
NetworkManager-0.9.9.1/src/ppp-manager/nm-pppd-plugin.c:262: var_compare_op: Comparing "username" to null implies that "username" might be null.
NetworkManager-0.9.9.1/src/ppp-manager/nm-pppd-plugin.c:291: var_deref_model: Passing null pointer "username" to function "strncpy(char * restrict, char const * restrict, size_t)", which dereferences it.

Error: NULL_RETURNS (CWE-476): [#def23]
NetworkManager-0.9.9.1/src/settings/nm-agent-manager.c:459: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/src/settings/nm-agent-manager.c:459: var_assigned: Assigning: "req" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/src/settings/nm-agent-manager.c:460: dereference: Dereferencing a null pointer "req".

Error: NULL_RETURNS (CWE-476): [#def24]
NetworkManager-0.9.9.1/src/settings/nm-settings-connection.c:1813: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/src/settings/nm-settings-connection.c:1813: var_assigned: Assigning: "list" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/src/settings/nm-settings-connection.c:1816: dereference: Dereferencing a null pointer "list".

Error: USE_AFTER_FREE (CWE-825): [#def25]
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/reader.c:228: freed_arg: "g_free(gpointer)" frees "value".
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/reader.c:231: pass_freed_arg: Passing freed pointer "value" as an argument to function "g_object_set(gpointer, gchar const *, ...)".

Error: RESOURCE_LEAK (CWE-772): [#def26]
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/shvar.c:73: alloc_fn: Storage is returned from allocation function "g_malloc(gsize)".
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/shvar.c:73: var_assign: Assigning: "arena" = storage returned from "g_malloc(buf.st_size + 1L)".
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/shvar.c:77: noescape: Resource "arena + total" is not freed or pointed-to in function "read(int, void *, size_t)".
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/shvar.c:77: noescape: Resource "arena + total" is not freed or pointed-to in function "read(int, void *, size_t)".
NetworkManager-0.9.9.1/src/settings/plugins/ifcfg-rh/shvar.c:82: leaked_storage: Variable "arena" going out of scope leaks the storage it points to.

Error: NULL_RETURNS (CWE-476): [#def27]
NetworkManager-0.9.9.1/src/wifi/wifi-utils-nl80211.c:696: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/src/wifi/wifi-utils-nl80211.c:696: var_assigned: Assigning: "info->freqs" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/src/wifi/wifi-utils-nl80211.c:712: dereference: Dereferencing a null pointer "info->freqs".

Error: NULL_RETURNS (CWE-476): [#def28]
NetworkManager-0.9.9.1/src/wifi/wifi-utils.c:40: returned_null: Function "g_malloc0(gsize)" returns null.
NetworkManager-0.9.9.1/src/wifi/wifi-utils.c:40: var_assigned: Assigning: "data" = null return value from "g_malloc0(gsize)".
NetworkManager-0.9.9.1/src/wifi/wifi-utils.c:41: dereference: Dereferencing a null pointer "data".

Error: FORWARD_NULL (CWE-476): [#def29]
NetworkManager-0.9.9.1/tui/nm-editor-utils.c:326: assign_zero: Assigning: "type_data" = "NULL".
NetworkManager-0.9.9.1/tui/nm-editor-utils.c:368: var_deref_op: Dereferencing null pointer "type_data".

Error: INFINITE_LOOP (CWE-835): [#def30]
NetworkManager-0.9.9.1/tui/nmtui.c:258: loop_top: Top of the loop.
NetworkManager-0.9.9.1/tui/nmtui.c:259: loop_bottom: Bottom of the loop.
NetworkManager-0.9.9.1/tui/nmtui.c:258: loop_condition: If "got_connections" is initially true then it will remain true.

Scan Properties