From 9dbad9ff5c7866e411600c4852f0dff0b92b3fd2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Miguel=20Par=C3=ADs=20D=C3=ADaz?= <mparisdiaz@gmail.com>
Date: Thu, 6 Nov 2014 12:40:39 +0100
Subject: [PATCH 05/13] rtpstats: RTP_MAX_MISORDER as 3000
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

RTP_MAX_MISORDER is used to reset stats following RFC3550.
But the point here is that this value (100) are based on
this sentence:
  "Typical values for the parameters are shown, based on a maximum
  misordering time of 2 seconds at 50 packets/second and a maximum
  dropout of 1 minute."

The assumption of this case causes problems when NACKs are used (RFC4585),
because misordering of 100 packets or more can be get.
At this point, stats are reset and some important RR fields as packets_lost
and fraction_lost get not according values.

Signed-off-by: Miguel París Díaz <mparisdiaz@gmail.com>
---
 gst/rtpmanager/rtpstats.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gst/rtpmanager/rtpstats.h b/gst/rtpmanager/rtpstats.h
index 1f09ffa..50c33f6 100644
--- a/gst/rtpmanager/rtpstats.h
+++ b/gst/rtpmanager/rtpstats.h
@@ -185,7 +185,7 @@ typedef struct {
  * The maximum number of misordered packets we tollerate. These are packets with
  * a sequence number smaller than the last seen packet.
  */
-#define RTP_MAX_MISORDER     100
+#define RTP_MAX_MISORDER     3000
 
 /**
  * RTPSessionStats:
-- 
1.9.1

