After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 784877 - Don't use variable for gettext package name
Don't use variable for gettext package name
Status: RESOLVED WONTFIX
Product: evolution-data-server
Classification: Platform
Component: general
unspecified
Other Linux
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2017-07-12 21:27 UTC by Jeremy Bicha
Modified: 2017-07-13 08:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Bug 784877 - Don't use variable for gettext package name (723 bytes, patch)
2017-07-12 21:29 UTC, Jeremy Bicha 		rejected Details | Review
Bug 784877 - Don't use variable for gettext package name - evolution (734 bytes, patch)
2017-07-12 21:34 UTC, Jeremy Bicha 		rejected Details | Review

Description Jeremy Bicha 2017-07-12 21:27:53 UTC 
The Ubuntu tool dh_translations isn't smart enough to follow the CMake variable to get to the translation domain. I'm attaching patches we are applying in Ubuntu to work around this.
Comment 1 Jeremy Bicha 2017-07-12 21:29:53 UTC 
Created attachment 355456 [details] [review]
Bug 784877 - Don't use variable for gettext package name

Patch for evolution-data-server
Comment 2 Jeremy Bicha 2017-07-12 21:34:52 UTC 
Created attachment 355457 [details] [review]
Bug 784877 - Don't use variable for gettext package name - evolution

Patch for evolution
Comment 3 Jeremy Bicha 2017-07-12 21:36:20 UTC 
The other evolution projects like evolution-ews aren't part of Ubuntu's language packs.
Comment 4 Milan Crha 2017-07-13 08:14:55 UTC 
Thanks for a bug report, but I'm sorry, I'm not going to accept this. The generality of these lines is the main advantage I liked on that notation. You should fix your tools, or enhance it to get the data from elsewhere, like from ${PROJECT_NAME}-config.h, where the GETTEXT_PACKAGE is defined.