After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 782610 - Massive logging: gcal_log ignores log levels
Massive logging: gcal_log ignores log levels
Status: RESOLVED FIXED
Product: gnome-calendar
Classification: Applications
Component: General
3.24.x
Other Linux
: Normal normal
: 3.26
Assigned To: GNOME Calendar maintainers
GNOME Calendar maintainers
Depends on:
Blocks:
 
 
Reported: 2017-05-14 00:29 UTC by Christian Stadelmann
Modified: 2017-05-17 13:10 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Christian Stadelmann 2017-05-14 00:29:50 UTC
When running gnome-calendar 3.24.2 on Fedora 25, I get hundreds of these warnings per hour:

GdkPixbuf:    DEBUG: gdk_pixbuf_from_pixdata() called on:
GdkPixbuf:    DEBUG:         Encoding raw
GdkPixbuf:    DEBUG:         Dimensions: 14 x 14
GdkPixbuf:    DEBUG:         Rowstride: 56, Length: 808
GdkPixbuf:    DEBUG:         Copy pixels == false

and also thousands of warnings per hour of these:

Gtk: CRITICAL: gtk_widget_get_realized: assertion 'GTK_IS_WIDGET (widget)' failed

plus some other warnings and debug output.
Comment 1 Georges Basile Stavracas Neto 2017-05-17 12:09:10 UTC
This problem has been fixed in our software repository. The fix will go into the next software release. Once that release is available, you may want to check for a software upgrade provided by your Linux distribution.

See commit b4fb259 for more information.

Thanks for your time.
Comment 2 Christian Stadelmann 2017-05-17 12:40:29 UTC
I've seen your fix, but the cause for this bug is somewhere else. It looks like gnome-calendar is printing all logging output on DEBUG level, even though it should default to WARNING level. Just ignoring the GdkPixbuf messages is a bad idea, because there could be useful GdkPixbuf warnings or errors.

What does gnome-calendar need its own logging handler for? Isn't it enough to use the default log handler of glib? It already supports log levels (and defaults to a reasonable value). And if you need to get a different log level for debugging, GLib should have enough for you: https://developer.gnome.org/glib/stable/glib-running.html
Comment 3 Christian Stadelmann 2017-05-17 12:41:56 UTC
Or, to rephrase comment #2:
Your commit is a workaround, not a fix. The output would be ok if I set the log level to DEBUG, but I didn't.
Comment 4 Christian Stadelmann 2017-05-17 13:10:02 UTC
Oh, f25a7b0dd8ceca28ce2b0bee8b102795b7a335dd does the job: https://git.gnome.org/browse/gnome-calendar/commit/?id=f25a7b0dd8ceca28ce2b0bee8b102795b7a335dd

Sorry for the noise and thanks for the fast fix!