After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 779507 - Reconsider dropping system-file-manager icon
Reconsider dropping system-file-manager icon
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: adwaita-icon-theme maintainer(s)
adwaita-icon-theme maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2017-03-03 03:59 UTC by Jeremy Bicha
Modified: 2017-03-10 10:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
revert removal of system-file-manager (50.78 KB, patch)
2017-03-09 23:58 UTC, Jeremy Bicha
committed Details | Review

Description Jeremy Bicha 2017-03-03 03:59:55 UTC
You dropped the system-file-manager icon because it's no longer used by Nautilus.

However, many (all?) other file managers have this icon name listed in their .desktop. This means that they will be shown with a missing icon on a standard GNOME system without any other icon themes installed.

Therefore, please consider adding it back.
Comment 1 Jeremy Bicha 2017-03-05 20:02:56 UTC
system-file-manager is listed here:
https://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Comment 2 Allan Day 2017-03-06 09:52:14 UTC
(In reply to Jeremy Bicha from comment #0)
...
> However, many (all?) other file managers have this icon name listed in their
> .desktop. ...

Can you give some examples?
Comment 3 Jeremy Bicha 2017-03-06 12:25:59 UTC
Good question.

Uses system-file-manger
=======================
https://sources.debian.net/src/kde-baseapps/4:16.08.3-1/dolphin/src/dolphin.desktop/?hl=91#L91

https://sources.debian.net/src/kde-baseapps/4:16.08.3-1/konqueror/konqueror.desktop/#L189

https://sources.debian.net/src/caja/1.16.2-2/data/caja.desktop.in.in/#L5

https://github.com/ukui/peony/blob/master/data/peony.desktop.in.in#L5
(Peony is the new fork of caja for UKUI, a new interface from Ubuntu Kylin. Peony is designed to resemble Windows Explorer.)

https://sources.debian.net/src/pcmanfm/1.2.5-2/data/pcmanfm.desktop.in/#L3

Does not
========
https://sources.debian.net/src/kde-baseapps/4:16.08.3-1/konqueror/settings/konq/filebehavior.desktop/?hl=5#L5
(It looks like the main konqueror .desktop doesn't use the icon but this one does.)

https://sources.debian.net/src/nemo/3.2.2-3/data/nemo.desktop.in.in/#L279

https://sources.debian.net/src/thunar/1.6.11-1/Thunar.desktop.in.in/#L6

Also affected
=============
https://git.gnome.org/browse/gtk+/tree/demos/icon-browser/iconbrowserwin.c#n522

Many icon themes assume that they'll be able to override the nautilus app icon. This doesn't seem that important for GNOME; they can just add a symlink. I had to do this for 2 default Ubuntu (Unity) themes and I pinged some of the other Ubuntu flavors for their default icon themes.
Comment 4 Jeremy Bicha 2017-03-09 23:58:34 UTC
Created attachment 347590 [details] [review]
revert removal of system-file-manager

It's still used by other file browsers
and it's part of the icon naming specification

https://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html
Comment 5 Jakub Steiner 2017-03-10 10:58:56 UTC
Attachment 347590 [details] pushed as a4dd9da - revert removal of system-file-manager