After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 771964 - regression in 0.34: support for abstract methods with generics
regression in 0.34: support for abstract methods with generics
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Semantic Analyzer
0.34.x
Other Linux
: Normal major
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-09-25 23:04 UTC by Sebastian Reichel
Modified: 2016-09-27 13:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
testcase for abstract method with generic (301 bytes, text/plain)
2016-09-25 23:04 UTC, Sebastian Reichel 		Details

Description Sebastian Reichel 2016-09-25 23:04:24 UTC 
Created attachment 336241 [details]
testcase for abstract method with generic

Hi,

The attached testcase code worked flawlessly with vala 0.32, but no longer works with vala 0.34. This breaks at least the freesmartphone.org stack, which makes heavy use of abstract methods in combination with generics. The problem has been introduced by https://mail.gnome.org/archives/commits-list/2016-July/msg02876.html as far as I can see.

-- Sebastian

Downstream Bug-Report: https://bugs.debian.org/838829
Comment 1 Jürg Billeter 2016-09-26 18:13:25 UTC 
commit dadf2b48d4da3f1afd95991bec4d4179e231b010
Author: Jürg Billeter <j@bitron.ch>
Date:   Mon Sep 26 19:07:17 2016 +0200

    Fix type parameter check for overriding generic methods
    
    https://bugzilla.gnome.org/show_bug.cgi?id=771964
    
    Reported-by: Sebastian Reichel <sre@ring0.de>
Comment 2 Jürg Billeter 2016-09-26 18:18:11 UTC 
Can you again build the fso stack with vala master with this fix or do you see further issues?
Comment 3 Sebastian Reichel 2016-09-26 19:44:56 UTC 
I will have a look at it tomorrow.
Comment 4 Sebastian Reichel 2016-09-26 21:23:38 UTC 
Ok. I just found some time to do it and the FSO core libraries build sucessfully with the patch. Thanks for taking care of it.
Comment 5 Jürg Billeter 2016-09-27 03:51:00 UTC 
Great, thanks for verifying. The patch is now also in the 0.34 branch.
Comment 6 Daniel Espinosa 2016-09-27 13:26:11 UTC 
This patch introduce an API change, If I'm not wrong. If so this should be stated and release as soon as possible, just if this change is absolutely necessary, I thing.