After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 756076 - Critical warning when loading an authenticated proxy resource from the disk cache
Critical warning when loading an authenticated proxy resource from the disk c...
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: HTTP Transport
2.52.x
Other Linux
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
Depends on:
Blocks:
 
 
Reported: 2015-10-05 11:08 UTC by Carlos Garcia Campos
Modified: 2015-10-08 07:00 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix runtime critical warning when loading an authenticated proxy resource from the disk cache (4.17 KB, patch)
2015-10-05 11:12 UTC, Carlos Garcia Campos
committed Details | Review

Description Carlos Garcia Campos 2015-10-05 11:08:57 UTC
It happens when we load a resource that goes through an authenticated proxy, and is cached in the disk. If the same resource is loaded again the response is sent from the cache, and the auth manager tries to get the proxy uri from the item connection. But there's no connection when loading cached resources.
I've written a test:

/proxy/auth-cache: 
(proxy-test:24348): libsoup-CRITICAL **: soup_connection_get_proxy_uri: assertion 'SOUP_IS_CONNECTION (conn)' failed

This is actually harmless, because NULL is returned and correctly handled, but we shouldn't show critical warnings anyway.
Comment 1 Carlos Garcia Campos 2015-10-05 11:12:05 UTC
Created attachment 312670 [details] [review]
Fix runtime critical warning when loading an authenticated proxy resource from the disk cache
Comment 2 Carlos Garcia Campos 2015-10-08 06:59:53 UTC
Comment on attachment 312670 [details] [review]
Fix runtime critical warning when loading an authenticated proxy resource from the disk cache

Pushed.