GNOME Bugzilla – Bug 745346
Use traditional title bars on Unity
Last modified: 2017-09-18 00:26:41 UTC
Ubuntu does not use headerbars in Unity. There are probably also DE's that don't want these. Use "gtk-dialogs-use-header" setting to determine wether to use headerbars
Created attachment 298193 [details] [review] Use traditional titlebars in Unity Use "gtk-dialogs-use-header" setting to determine wether to use headerbars
I'm not aware of any other GNOME application doing this, can you link at an example? I'd like to keep baobab coherent with the gnome ecosystem.
At least in gedit we are considering it. We use it to not have different UI on OSX, for the unity we did not decide yet since we do not like removing the magic open button... anyway this is OT :-) darkxst: can you attach a screenshot of the result?
(In reply to Paolo Borelli from comment #3) > At least in gedit we are considering it. We use it to not have different UI > on OSX, for the unity we did not decide yet since we do not like removing > the magic open button... anyway this is OT :-) > Bleagh, I should not write while listening to another conversation... what I meant is: "We use it to have a different UI on OSX, for unity we did not decide yet..."
quite a few apps do this, a few examples: https://git.gnome.org/browse/cheese/commit/?id=f0edb1f9794cebe0f5be8052824e7e07d023efc8 https://git.gnome.org/browse/gnome-sudoku/commit/?id=e4754cdc69de7752b615b374cc1682adcf91b864 https://git.gnome.org/browse/gnome-system-monitor/commit/?id=a486e06d8ff45cc99508a2b82da96fc5225d3e80
Created attachment 298228 [details] screenshot
I am not opposed to this in principle, but that looks pretty bad...
(In reply to Paolo Borelli from comment #7) > I am not opposed to this in principle, but that looks pretty bad... Agree.. If the goal is making the app look good in Unity, I'm not sure this is the way
that screenshot was with the gnome theme, and some unrelated theme issues from gtk 3.15. The Ubuntu themes actually sytle the GtkHeaderBar widget differently (no rounded corners for example)
Created attachment 298230 [details] Unity Screenshot This is what it actually looks like under Unity
Created attachment 298231 [details] [review] Use traditional titlebars in Unity Use "gtk-dialogs-use-header" setting to determine wether to use headerbars Need to remove "titlebar" style class also
In any case, I think that it would be better to check explicitly that XDG_CURRENT_DESKTOP=="Unity" instead of using the gtk-dialogs-use-header setting
OK, if you prefer, although its not really generic in that case, there are other DE's out there that don't like headerbars, and while in Ubuntu most of these legacy type DE's use Unity for XDG_CURRENT_DESKTOP currently (I believe), not sure what happens in other distros. I was previously using XDG_CURRENT_DESKTOP!="GNOME" in most of my patches, but then maybe there are others that want them? most of the recent patches I have seen are now using gtk-dialogs-use-header, some may be ubuntu specific though.
Created attachment 298353 [details] [review] Use traditional titlebars in Unity Use XDG_CURRENT_DESKTOP to determine whether to display headerbars as a toolbar on Unity
Since nearly all DEs except gnome prefer titlebars, could the XDG_CURRENT_DESKTOP setting be !gnome instead of only working on unity?
(In reply to Jackson Doak from comment #15) > Since nearly all DEs except gnome prefer titlebars, could the > XDG_CURRENT_DESKTOP setting be !gnome instead of only working on unity? As you can see from the screenshot in commment 6, traditional titlebar+headerbar look quite broken, unless properly styled, so I'd rather keep it non generic and then add more exceptions... I don't know maybe this should be solved at the toolkit level
Created attachment 359020 [details] [review] Use traditional titlebars in Unity Here's a rebased version of the patch that Ubuntu has been carrying. Please review.
Attachment 359020 [details] pushed as 9247a47 - Use traditional titlebars in Unity
Does this patch still make sense now that Unity has been discontinued by Canonical?