After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 736407 - media-server: Use a hyphen instead of underscore in provider type
media-server: Use a hyphen instead of underscore in provider type
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.13.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-09-10 10:59 UTC by Debarshi Ray
Modified: 2014-09-10 12:30 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
media-server: Use a hyphen instead of underscore in provider type (875 bytes, patch)
2014-09-10 11:02 UTC, Debarshi Ray 		committed Details | Review
media-server: Use a hyphen instead of underscore in provider type (896 bytes, patch)
2014-09-10 11:05 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-09-10 10:59:52 UTC 
Data coming from media servers are stored in tracker with an identifier prefixed with 'media-server', not 'media_server'. Having the GOA provider type match the tracker identifier prefix makes things simpler by removing an unnecessary inconsistency. See bug 731865 for an example.

We could choose either 'media-server' or 'media_server' as long as we are consistent. Personally I like the hyphen because it looks nicer outside C code.
Comment 1 Debarshi Ray 2014-09-10 11:02:48 UTC 
Created attachment 285816 [details] [review]
media-server: Use a hyphen instead of underscore in provider type
Comment 2 Debarshi Ray 2014-09-10 11:05:07 UTC 
Created attachment 285817 [details] [review]
media-server: Use a hyphen instead of underscore in provider type