After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 727896 - IdentityService crashes on startup if KerberosIdentityManager could not be created
IdentityService crashes on startup if KerberosIdentityManager could not be cr...
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: Kerberos
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-04-09 13:20 UTC by Debarshi Ray
Modified: 2014-04-09 14:06 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
kerberos: Correctly set the error if object creation failed (1.04 KB, patch)
2014-04-09 13:28 UTC, Debarshi Ray 		committed Details | Review
identity: Keep a reference to self during async operations (2.25 KB, patch)
2014-04-09 13:33 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-04-09 13:20:09 UTC 
If goa_kerberos_identity_manager_new fails, the error is not correctly set.

See: https://bugzilla.redhat.com/show_bug.cgi?id=1085721
Comment 1 Debarshi Ray 2014-04-09 13:28:54 UTC 
Created attachment 273893 [details] [review]
kerberos: Correctly set the error if object creation failed
Comment 2 Debarshi Ray 2014-04-09 13:33:21 UTC 
Created attachment 273894 [details] [review]
identity: Keep a reference to self during async operations
Comment 3 Ray Strode [halfline] 2014-04-09 13:53:02 UTC 
Review of attachment 273894 [details] [review]:

I think this is a good idea, but it needs a little more explanation in the commit message.

Maybe something:

If the IdentityService object is freed while it's getting the initial list of identities shortly after start up (i.e., the service is exiting shortly after starting), then there's a chance the callback associated with the identity listing operation could be called after the service is freed (which could lead to a crash).

This commit addresses that problem by reffing the service object until the list operation finishes, preventing it from getting freed prematurely.
Comment 4 Debarshi Ray 2014-04-09 14:06:17 UTC 
Comment on attachment 273894 [details] [review]
identity: Keep a reference to self during async operations

Updated the commit message as suggested.