After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 726570 - should use Makefile.introspection
should use Makefile.introspection
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.11.x
Other OpenBSD
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-03-17 18:46 UTC by Antoine Jacoutot
Modified: 2014-04-22 12:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
do not hardcode path to libtool (1.06 KB, patch)
2014-04-09 14:53 UTC, Antoine Jacoutot
needs-work Details | Review
do not hardcode path to libtool v2 (1.72 KB, patch)
2014-04-18 12:21 UTC, Antoine Jacoutot
none Details | Review
do not hardcode path to libtool v3 (1.06 KB, patch)
2014-04-18 12:34 UTC, Antoine Jacoutot
committed Details | Review
build: Clean up uses of INCLUDES and _CPPFLAGS (4.90 KB, patch)
2014-04-22 12:46 UTC, Debarshi Ray
committed Details | Review
build: Use Makefile.introspection (2.31 KB, patch)
2014-04-22 12:46 UTC, Debarshi Ray
committed Details | Review

Description Antoine Jacoutot 2014-03-17 18:46:13 UTC
Hi.

No patch sorry, it's a bit too much goi/autotools voodoo for me...

The hand-rolled rules in the Makefile are missing some things that the m4 macros have -- particularly support for a non-standard libtool path.
See also: https://fedorahosted.org/libosinfo/ticket/11

On OpenBSD this allows using the OS provided libtool(1) (https://bugzilla.gnome.org/show_bug.cgi?id=726518) and fix the build.
Comment 1 Antoine Jacoutot 2014-04-09 14:53:32 UTC
Created attachment 273904 [details] [review]
do not hardcode path to libtool

Hi. This patch does the trick for me...
Comment 2 Antoine Jacoutot 2014-04-17 07:50:55 UTC
Hi. Any opinion on this?
Thanks.
Comment 3 Debarshi Ray 2014-04-18 11:52:34 UTC
Review of attachment 273904 [details] [review]:

Sorry about the delay.

::: src/goa/Makefile.am
@@ +135,3 @@
 		--pkg=gio-2.0 					\
 		--pkg-export=goa-1.0				\
+		--libtool=${LIBTOOL}				\

I think that it should be enclosed in quotes because on GNU/Linux it expands to /bin/sh ../../libtool. Without the quotes, when g-ir-scanner tries to link, the ../../libtool part gets dropped and only /bin/sh is used. That leads to a build failure because /bin/sh does not like --mode=link, etc. being passed to it.

And maybe we should use $(...) instead of ${...}?
Comment 4 Allison Karlitskaya (desrt) 2014-04-18 12:09:52 UTC
Why not use the standard m4 rules and Makefile.introspection here like everyone else?
Comment 5 Antoine Jacoutot 2014-04-18 12:20:19 UTC
> ::: src/goa/Makefile.am
> @@ +135,3 @@
>          --pkg=gio-2.0                     \
>          --pkg-export=goa-1.0                \
> +        --libtool=${LIBTOOL}                \
> 
> I think that it should be enclosed in quotes because on GNU/Linux it expands to
> /bin/sh ../../libtool. Without the quotes, when g-ir-scanner tries to link, the
> ../../libtool part gets dropped and only /bin/sh is used. That leads to a build
> failure because /bin/sh does not like --mode=link, etc. being passed to it.
> 
> And maybe we should use $(...) instead of ${...}?

Sure thing, new patch attached.
Comment 6 Antoine Jacoutot 2014-04-18 12:21:13 UTC
Created attachment 274663 [details] [review]
do not hardcode path to libtool v2
Comment 7 Antoine Jacoutot 2014-04-18 12:34:21 UTC
Created attachment 274667 [details] [review]
do not hardcode path to libtool v3

Bah, wrong project patch ;-)
Comment 8 Debarshi Ray 2014-04-18 12:34:42 UTC
(In reply to comment #4)
> Why not use the standard m4 rules and Makefile.introspection here like everyone
> else?

Yes, let's just do that. I will write a patch based on your libosinfo one.
Comment 9 Debarshi Ray 2014-04-18 12:42:13 UTC
Review of attachment 274667 [details] [review]:

I am going to try and move to using Makefile.introspection. In the meantime, lets commit this - it is just a one-liner.
Comment 10 Debarshi Ray 2014-04-22 12:46:16 UTC
Created attachment 274886 [details] [review]
build: Clean up uses of INCLUDES and _CPPFLAGS
Comment 11 Debarshi Ray 2014-04-22 12:46:53 UTC
Created attachment 274887 [details] [review]
build: Use Makefile.introspection
Comment 12 Debarshi Ray 2014-04-22 12:49:38 UTC
Review of attachment 274886 [details] [review]:

Committed.
Comment 13 Debarshi Ray 2014-04-22 12:50:00 UTC
Review of attachment 274887 [details] [review]:

Committed.