After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 711472 - [GOA] Disabling windows live mail from gnome-online-accounts doesn't remove it from Evolution
[GOA] Disabling windows live mail from gnome-online-accounts doesn't remove i...
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.10.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-11-05 10:30 UTC by Milan Crha
Modified: 2013-11-07 15:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch (1.21 KB, patch)
2013-11-07 15:34 UTC, Matthew Barnes
committed Details | Review

Description Milan Crha 2013-11-05 10:30:44 UTC
Moving this from a downstream bug report:
https://bugzilla.redhat.com/show_bug.cgi?id=1024008

Description of problem:
I set up windows live using GOA. Windows live doesn't work, but that's a different bug. I disabled windows live mail from GOA and used imap/smtp to access my mail. Even though it's disabled in goa, the mail account still shows up in Evolution.

Toggling it for gmail works just fine. 

Version-Release number of selected component (if applicable):
[asinha@ankur-laptop  fedora-appstream(master=)]$ rpm -q gnome-online-accounts
gnome-online-accounts-3.10.1-2.fc20.x86_64
[asinha@ankur-laptop  fedora-appstream(master=)]$ rpm -q evolution
evolution-3.10.1-1.fc20.x86_64
[asinha@ankur-laptop  fedora-appstream(master=)]$

How reproducible:
Always.

Steps to Reproduce:
1. Add windows live accounts
2. Disable mail in goa
3. check evolution

Actual results:
Account still shows

Expected results:
Account shouldnt show

Additional info:
Is it possible that the email erring out is causing the account to stick around for some reason? 

I can file this upstream if someone verifies it.
Comment 1 Matthew Barnes 2013-11-05 13:43:47 UTC
(In reply to comment #0)
> Version-Release number of selected component (if applicable):
> [asinha@ankur-laptop  fedora-appstream(master=)]$ rpm -q gnome-online-accounts
> gnome-online-accounts-3.10.1-2.fc20.x86_64
> [asinha@ankur-laptop  fedora-appstream(master=)]$ rpm -q evolution
> evolution-3.10.1-1.fc20.x86_64

Despite this, my guess is the reporter still had E-D-S 3.10.0 services running in the background, which did not know about Windows Live accounts through GOA since that feature was backported to E-D-S 3.10.1.

If so, a desktop session restart should correct this.

The enable/disable logic in the GOA module is the same for all account types.
Comment 2 Ankur Sinha (FranciscoD) 2013-11-06 01:26:13 UTC
Hi,

I've restarted my laptop a couple of times since updating so this shouldn't be an issue. I've created a screencast that should show you the issue properly. This is after another restart.

http://ankursinha.fedorapeople.org/Screencast-gnome-windows-online-accounts.webm


There's actually another bug that you'll see in the screencast too: the windows live online account e-mail doesn't work here. It gives an error as the screencast shows. I haven't reported this since it just might be a server side issue, the server being a university mail service.

Thanks,
Ankur
Comment 3 Ankur Sinha (FranciscoD) 2013-11-06 01:36:04 UTC
(In reply to comment #2)
> 
> There's actually another bug that you'll see in the screencast too: the windows
> live online account e-mail doesn't work here. It gives an error as the
> screencast shows. I haven't reported this since it just might be a server side
> issue, the server being a university mail service.

(Empathy can't connect to the chat service either which makes me think it's a server side problem. They've probably shut down these services.)
Comment 4 Gerad Munsch 2013-11-07 05:42:16 UTC
This bug effects me on ArchLinux, as well. Everything updated.
Comment 5 Matthew Barnes 2013-11-07 15:23:22 UTC
Seems to be a disconnect on the GOA side.

Flipping the ON/OFF switches while watching the D-Bus interface, I see the ChatDisabled and DocumentsDisable properties change but never MailDisabled.

This is with gnome-online-accounts-3.10.1-2.fc21.
Comment 6 Matthew Barnes 2013-11-07 15:34:51 UTC
Created attachment 259198 [details] [review]
Patch

This fixes it.  Looks like just an oversight.
Comment 7 Debarshi Ray 2013-11-07 15:46:16 UTC
Review of attachment 259198 [details] [review]:

Perfect. Thanks for catching this.