After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 707006 - Cannot build against webkitgtk-2.1.90
Cannot build against webkitgtk-2.1.90
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
3.9.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-28 17:07 UTC by Seán de Búrca
Modified: 2013-09-02 10:08 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix build against webkitgtk-2.1.90 (2.09 KB, patch)
2013-08-28 17:09 UTC, Seán de Búrca 		needs-work Details | Review
Fix build against webkitgtk-2.1.90, change required version in configure.ac (2.50 KB, patch)
2013-08-28 18:13 UTC, Seán de Búrca 		committed Details | Review
Fix the pointer types (1.30 KB, patch)
2013-09-02 10:08 UTC, Debarshi Ray 		committed Details | Review

Description Seán de Búrca 2013-08-28 17:07:27 UTC 
The most recent version of webkitgtk breaks API which gnome-online-accounts uses. webkit_dom_*_element_get_id() have been replaced with webkit_dom_element_get_id().
Comment 1 Seán de Búrca 2013-08-28 17:09:06 UTC 
Created attachment 253420 [details] [review]
Fix build against webkitgtk-2.1.90
Comment 2 Debarshi Ray 2013-08-28 17:30:05 UTC 
Review of attachment 253420 [details] [review]:

Please bump the webkitgtk-3.0 version in configure.ac as well.
Comment 3 Seán de Búrca 2013-08-28 18:13:38 UTC 
Created attachment 253426 [details] [review]
Fix build against webkitgtk-2.1.90, change required version in configure.ac

Done.
Comment 4 Debarshi Ray 2013-08-29 13:08:55 UTC 
Review of attachment 253426 [details] [review]:

Looks good, but the commit message should not exceed 72 characters. I committed it after fixing that.
Comment 5 Dominique Leuenberger 2013-09-02 07:17:46 UTC 
Just wondering: was this aligned as a long-term goal with the webkitgtk devs?
As in fact, this was also identified as an error there and fixed in 2.1.90.1 (re-introduced the missed APIs)
Comment 6 Seán de Búrca 2013-09-02 07:19:48 UTC 
The missing APIs are redirects to the functions now being called, as I understand it. In talking with a webkitgtk dev, I was led to believe the API calls should be changed moving forward, but that the redirects were added to prevent an API break.
Comment 7 Debarshi Ray 2013-09-02 09:29:36 UTC 
(In reply to comment #5)
> Just wondering: was this aligned as a long-term goal with the webkitgtk devs?
> As in fact, this was also identified as an error there and fixed in 2.1.90.1
> (re-introduced the missed APIs)

Yes, as Seán pointed out, the WebKitGTK+ developers think that the forward looking change would be to adopt the new APIs instead of sticking to the compatibility redirects.
Comment 8 Dominique Leuenberger 2013-09-02 09:32:28 UTC 
Thanks.. all clarified then;
Was just surprised to see two fixes popping up for the same issue.

g-o-a with this patch built successfully.
Comment 9 Debarshi Ray 2013-09-02 10:08:54 UTC 
Created attachment 253818 [details] [review]
Fix the pointer types

Fixes a few compiler warnings arising out of incorrect pointer types.