After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 706088 - Calling g_bus_unwatch_name() from watch name callbacks causes corruption
Calling g_bus_unwatch_name() from watch name callbacks causes corruption
Status: RESOLVED OBSOLETE
Product: glib
Classification: Platform
Component: gdbus
2.37.x
Other Linux
: Normal major
: ---
Assigned To: David Zeuthen (not reading bugmail)
gtkdev
Depends on:
Blocks:
 
 
Reported: 2013-08-15 20:05 UTC by Matthew Barnes
Modified: 2018-05-24 15:37 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Proposed patch (1.01 KB, patch)
2013-08-15 20:05 UTC, Matthew Barnes
reviewed Details | Review

Description Matthew Barnes 2013-08-15 20:05:39 UTC
Created attachment 251769 [details] [review]
Proposed patch

I observed this with the "name" argument, but looks like it can also happen with the "user_data" argument in these callback functions:

void  (*GBusNameAppearedCallback)  (GDBusConnection *connection,
                                    const gchar *name,
                                    const gchar *name_owner,
                                    gpointer user_data);

void  (*GBusNameVanishedCallback)  (GDBusConnection *connection,
                                    const gchar *name,
                                    gpointer user_data);

The actually_do_call() function should reference the "Client" struct before invoking either of these callbacks to keep them alive for the duration of the callback.
Comment 1 Colin Walters 2013-08-15 20:16:00 UTC
Review of attachment 251769 [details] [review]:

This looks correct, but can you formulate this as "git format-patch" style?  See https://live.gnome.org/GnomeLove/SubmittingPatches
Comment 2 GNOME Infrastructure Team 2018-05-24 15:37:06 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/745.