GNOME Bugzilla – Bug 706088
Calling g_bus_unwatch_name() from watch name callbacks causes corruption
Last modified: 2018-05-24 15:37:06 UTC
Created attachment 251769 [details] [review] Proposed patch I observed this with the "name" argument, but looks like it can also happen with the "user_data" argument in these callback functions: void (*GBusNameAppearedCallback) (GDBusConnection *connection, const gchar *name, const gchar *name_owner, gpointer user_data); void (*GBusNameVanishedCallback) (GDBusConnection *connection, const gchar *name, gpointer user_data); The actually_do_call() function should reference the "Client" struct before invoking either of these callbacks to keep them alive for the duration of the callback.
Review of attachment 251769 [details] [review]: This looks correct, but can you formulate this as "git format-patch" style? See https://live.gnome.org/GnomeLove/SubmittingPatches
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glib/issues/745.