After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 705607 - Navigation buttons fail to reappear on mouse motion and when previewing the same photo
Navigation buttons fail to reappear on mouse motion and when previewing the s...
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2013-08-07 11:37 UTC by Emanuele Aina
Modified: 2013-08-08 22:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
preview-view: Receive motion-notify-events (1.08 KB, patch)
2013-08-08 15:19 UTC, Debarshi Ray
committed Details | Review
preview-view: Always show the navigation buttons when a node is set (1.35 KB, patch)
2013-08-08 15:20 UTC, Debarshi Ray
committed Details | Review

Description Emanuele Aina 2013-08-07 11:37:34 UTC
* In overview mode, click on a picture to go in preview mode
* In preview mode, click on the right arrow to switch to the next picture
* Click on the gear button to open the menu and then re-click it to close the drop-down menu
* Observe the navigation buttons disappear, as photos_preview_nav_buttons_auto_hide() gets called
* Note that they won't reappear, no matter what you do

From my understanding the issue is that photos-preview-nav-buttons.c relies on the GtkWidget::motion-notify-event event being triggered on the main GtkOverlay, but since this widget does not have the GDK_POINTER_MOTION_MASK|GDK_POINTER_MOTION_HINT_MASK set, the motion notification callback is never invoked.

If that proves to be the case, inserting a GtkEventBox in the overlay or somewhere else may fix the problem.
Comment 1 Debarshi Ray 2013-08-08 15:04:13 UTC
Since this is a clone of gnome-documents' PreviewNavButtons, I was curious what might be causing this. It turns out that the EvView.View widget used by gnome-documents has GDK_POINTER_MOTION_MASK set on it, while our GeglGtkView doesn't have it. This is solved by setting the mask using gtk_widget_add_events.

There is another issue here, where you won't find the buttons if you went back to the overview and tried previewing the same photo again.

Patches coming up.
Comment 2 Debarshi Ray 2013-08-08 15:18:10 UTC
Updating the summary to reflect the 2nd issue.
Comment 3 Debarshi Ray 2013-08-08 15:19:59 UTC
Created attachment 251192 [details] [review]
preview-view: Receive motion-notify-events

I like this option because it reduces the delta with gnome-documents.
Comment 4 Debarshi Ray 2013-08-08 15:20:31 UTC
Created attachment 251193 [details] [review]
preview-view: Always show the navigation buttons when a node is set