After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 704822 - g-c-c 3.8.4 build failure
g-c-c 3.8.4 build failure
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Date and Time
3.8.x
Other Linux
: Normal normal
: ---
Assigned To: Zeeshan Ali
Control-Center Maintainers
: 704839 704850 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2013-07-24 17:10 UTC by Jan Alexander Steffens (heftig)
Modified: 2015-03-19 11:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Jan Alexander Steffens (heftig) 2013-07-24 17:10:24 UTC
Regression attempting to build 3.8.4:

  CC       timedated.lo
  CC       cc-datetime-panel.lo
  CC       cc-datetime-resources.lo
  CC       cc-timezone-map.lo
In file included from /usr/include/glib-2.0/gobject/gobject.h:26:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:31,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from /usr/include/glib-2.0/gio/gioenums.h:30,
                 from /usr/include/glib-2.0/gio/giotypes.h:30,
                 from /usr/include/glib-2.0/gio/gio.h:28,
                 from timedated.h:10,
                 from timedated.c:11:
timedated.c: In function 'timedate1_proxy_get_type':
timedated.c:1253:41: error: expected expression before 'Timedate1Proxy'
                          G_ADD_PRIVATE (Timedate1Proxy)
                                         ^
/usr/include/glib-2.0/gobject/gtype.h:1334:105: note: in definition of macro 'G_DEFINE_TYPE_WITH_CODE'
 #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)     _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                                                         ^
/usr/include/glib-2.0/gobject/gtype.h:1481:61: error: expected ';' before '{' token
 #define G_IMPLEMENT_INTERFACE(TYPE_IFACE, iface_init)       { \
                                                             ^
/usr/include/glib-2.0/gobject/gtype.h:1334:105: note: in definition of macro 'G_DEFINE_TYPE_WITH_CODE'
 #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)     _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                                                         ^
timedated.c:1254:26: note: in expansion of macro 'G_IMPLEMENT_INTERFACE'
                          G_IMPLEMENT_INTERFACE (TYPE_TIMEDATE1, timedate1_proxy_iface_init));
                          ^
timedated.c: In function 'timedate1_proxy_init':
timedated.c:1443:15: warning: assignment makes pointer from integer without a cast [enabled by default]
   proxy->priv = timedate1_proxy_get_instance_private (proxy);
               ^
In file included from /usr/include/glib-2.0/gobject/gobject.h:26:0,
                 from /usr/include/glib-2.0/gobject/gbinding.h:31,
                 from /usr/include/glib-2.0/glib-object.h:25,
                 from /usr/include/glib-2.0/gio/gioenums.h:30,
                 from /usr/include/glib-2.0/gio/giotypes.h:30,
                 from /usr/include/glib-2.0/gio/gio.h:28,
                 from timedated.h:10,
                 from timedated.c:11:
timedated.c: In function 'timedate1_skeleton_get_type':
timedated.c:1884:41: error: expected expression before 'Timedate1Skeleton'
                          G_ADD_PRIVATE (Timedate1Skeleton)
                                         ^
/usr/include/glib-2.0/gobject/gtype.h:1334:105: note: in definition of macro 'G_DEFINE_TYPE_WITH_CODE'
 #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)     _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                                                         ^
/usr/include/glib-2.0/gobject/gtype.h:1481:61: error: expected ';' before '{' token
 #define G_IMPLEMENT_INTERFACE(TYPE_IFACE, iface_init)       { \
                                                             ^
/usr/include/glib-2.0/gobject/gtype.h:1334:105: note: in definition of macro 'G_DEFINE_TYPE_WITH_CODE'
 #define G_DEFINE_TYPE_WITH_CODE(TN, t_n, T_P, _C_)     _G_DEFINE_TYPE_EXTENDED_BEGIN (TN, t_n, T_P, 0) {_C_;} _G_DEFINE_TYPE_EXTENDED_END()
                                                                                                         ^
timedated.c:1885:26: note: in expansion of macro 'G_IMPLEMENT_INTERFACE'
                          G_IMPLEMENT_INTERFACE (TYPE_TIMEDATE1, timedate1_skeleton_iface_init));
                          ^
timedated.c: In function 'timedate1_skeleton_init':
timedated.c:2044:18: warning: assignment makes pointer from integer without a cast [enabled by default]
   skeleton->priv = timedate1_skeleton_get_instance_private (skeleton);
                  ^
make[5]: *** [timedated.lo] Error 1
make[5]: *** Waiting for unfinished jobs....
make[4]: *** [all-recursive] Error 1
make[3]: *** [all] Error 2
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

I believe that the tarball was created on a system with a too-recent glib. The build system has 2.36.3.
Comment 1 Zeeshan Ali 2013-07-24 18:35:45 UTC
IMO these files generated files (timedated.[ch]) should not be in the tarball in the first place. Looking at the Makefile.am, I don't see why they get included in the tarball since EXTRA_DIST doesn't list these files.
Comment 2 Bastien Nocera 2013-07-24 22:04:57 UTC
*** Bug 704839 has been marked as a duplicate of this bug. ***
Comment 3 Bastien Nocera 2013-07-25 07:35:36 UTC
*** Bug 704850 has been marked as a duplicate of this bug. ***
Comment 4 Bastien Nocera 2013-07-25 08:46:34 UTC
Fixed in 3.8.4.1
Comment 5 Pacho Ramos 2015-03-19 11:30:40 UTC
They are still present in 3.14.3 tarball
Comment 6 Bastien Nocera 2015-03-19 11:48:46 UTC
(In reply to Pacho Ramos from comment #5)
> They are still present in 3.14.3 tarball

That's not what the original bug was about, and unless it causes problems, best left as-is. File a new bug if it's a problem.