GNOME Bugzilla – Bug 701964
evolution-data-server provider not displayed in UOA.
Last modified: 2013-06-22 23:40:05 UTC
When using UOA module there is no way to toggle e-d-s integration on/off due to missing desktop file * credentials-cc-panel-Message: cc-credentials-providers-model.vala:109: No desktop app info found for application name: evolution-data-server
Created attachment 246453 [details] [review] uoa: add desktop_entry so that e-d-s provider is displayed in uoa This patch fixes the issue, however perhaps it would be better for e-d-s to install its own desktop file, since integration should work across the GNOME stack and the e-d-s provider won't be displayed if evolution is not installed.
Comment on attachment 246453 [details] [review] uoa: add desktop_entry so that e-d-s provider is displayed in uoa It's a conundrum, because it's not really appropriate for E-D-S to ship its own desktop file (what would launching it do?), but at the same time E-D-S should not be favoring one E-D-S client over others. Not even Evolution.
well the credentials panel only seems to use the desktop file for finding the icon.
Could you see e-d-s shipping a minimal .desktop file with no Exec= and with NoDisplay=true to support this? Then it wouldn't interfere with launchers. We could even go as far as installing it only when UOA support is enabled if you like?
Created attachment 246624 [details] [review] Add a desktop file for Ubuntu Online Accounts This is required for E-D-S to show up in the Ubuntu Online Accounts configuration UI. It's only installed when built with UOA.
Comment on attachment 246624 [details] [review] Add a desktop file for Ubuntu Online Accounts Thanks. I guess a minimal .desktop file is acceptable for now, although I would prefer it live in modules/ubuntu-online-accounts/ instead of data/, since it's exclusively for UOA. Then you don't have to check for HAVE_UOA. Wondering also if it should be renamed to something like eds-for-uoa.desktop, just to make its purpose clear. A comment to this effect in the .desktop file itself would not hurt either. There should be no other use case for E-D-S shipping a .desktop file. It's kind of lame on UOA's part to assume all clients would have a .desktop file in the first place. It could just fall back to a translatable <description> tag or allow for some other way to provide the application name inline.
Created attachment 246697 [details] [review] Add a desktop file for Ubuntu Online Accounts This is required for E-D-S to show up in the Ubuntu Online Accounts configuration UI. It's only installed when built with UOA.
Created attachment 246698 [details] [review] Add some descriptions to the UOA service types. This causes them to appear separately in the UOA UI, together with user-level descriptions.
The second one is an opportunistic thing I just saw. I could file a new bug about it if you like. The wordings I chose are just a strawman - feel free to change.
What do you think about adding Icon=evolution to the new .desktop? EDS looks a bit out of place with no icon in the UOA list.
(In reply to comment #10) > What do you think about adding Icon=evolution to the new .desktop? EDS looks a > bit out of place with no icon in the UOA list. Well, see comment #2. It should be expected that some UOA clients do not have their own icon.
Ultimately it would make most sense for EDS to ship its own icon. But that's probably not something I'm going to work on (unless just copying Evo's or using some generic icon would work).
Honestly, if EDS doesn't have its own icon to include, I think Ubuntu will patch the .desktop to add Icon=evolution. Patching doesn't make a lot of sense since I don't think anyone except Ubuntu is using the UOA module yet. Since Ubuntu includes Thunderbird by default instead of Evolution I don't think the icon is particularly recognizable as Evolution. Evolution's icon is pretty generic these days anyway.
Review of attachment 246697 [details] [review]: Committed the desktop file patch with a few tweaks: https://git.gnome.org/browse/evolution-data-server/commit/?id=61b357eed343d98e63ac898440759fea18067f53
Review of attachment 246698 [details] [review]: This is a good idea. I took it a little further and added service-specific descriptions. https://git.gnome.org/browse/evolution-data-server/commit/?id=61b357eed343d98e63ac898440759fea18067f53
As for the icon issue, it occurred to me the service-type files already specify generic stock icon names. For example, calendar.service-type has <icon>x-office-calendar</icon>. That's even more appropriate than reusing Evolution's icon, in my opinion, especially since each E-D-S service is shown separately now. If a desktop file doesn't specify an Icon, then I would expect UOA to fall back to the icon specified in the <service>, or else <service-type> definition. Closing this as FIXED.
(In reply to comment #15) > Review of attachment 246698 [details] [review]: > > This is a good idea. I took it a little further and added service-specific > descriptions. Wrong link. Here's the right one: https://git.gnome.org/browse/evolution-data-server/commit/?id=d2f6281696627ca4e13a28a917b1f7bd0e9a3bcc