After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 701500 - Photo support for Facebook provider
Photo support for Facebook provider
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other Linux
: Normal enhancement
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks: 700451
 
 
Reported: 2013-06-03 09:24 UTC by Álvaro Peña
Modified: 2013-09-10 12:46 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
The few lines to allow photo support to the Facebook provider (4.06 KB, patch)
2013-06-03 09:26 UTC, Álvaro Peña
reviewed Details | Review
facebook: Add support for photos (4.05 KB, patch)
2013-06-03 11:26 UTC, Debarshi Ray
committed Details | Review
build: Don't hard code the paths to girdir and typelibdir (953 bytes, patch)
2013-06-03 11:27 UTC, Debarshi Ray
committed Details | Review

Description Álvaro Peña 2013-06-03 09:24:23 UTC
Hi!

I'm working in the Facebook Photo support for GNOME Photos and I'm using the GOA as the authorizer, so I need to add some new authorizations and other things.
Comment 1 Álvaro Peña 2013-06-03 09:26:03 UTC
Created attachment 245899 [details] [review]
The few lines to allow photo support to the Facebook provider
Comment 2 Debarshi Ray 2013-06-03 11:25:47 UTC
Review of attachment 245899 [details] [review]:

Thanks for the patch. Looks good, apart from a few minor things.

::: src/goa/Makefile.am
@@ +119,3 @@
 typelibs_DATA = Goa-1.0.typelib
 
 Goa-1.0.gir: $(libgoa_1_0_la_SOURCES)

It would be nice to put this into a separate patch.

::: src/goabackend/goafacebookprovider.c
@@ +143,2 @@
 }
 

We also have to bump the value returned by the get_credentials_generation vfunc. This is needed because older access_tokens won't work with the new set of scopes.
Comment 3 Debarshi Ray 2013-06-03 11:26:33 UTC
Created attachment 245909 [details] [review]
facebook: Add support for photos
Comment 4 Debarshi Ray 2013-06-03 11:27:03 UTC
Created attachment 245910 [details] [review]
build: Don't hard code the paths to girdir and typelibdir
Comment 5 Debarshi Ray 2013-06-03 11:29:09 UTC
Thank you very much for your work on improving the integration with Facebook.
Comment 6 Michael Biebl 2013-09-10 12:40:05 UTC
(In reply to comment #4)
> Created an attachment (id=245910) [details] [review]
> build: Don't hard code the paths to girdir and typelibdir

Hm, that patch and especially the commit message doesn't make sense.
What the patch does is *actually* hard-code the gir and typelibdir paths instead of getting the proper paths from gobject-introspection-1.0.pc.

The two variables are defined as
INTROSPECTION_GIRDIR=`$PKG_CONFIG --variable=girdir gobject-introspection-1.0`
INTROSPECTION_TYPELIBDIR=`$($PKG_CONFIG --variable=typelibdir gobject-introspection-1.0)`
Comment 7 Michael Biebl 2013-09-10 12:46:23 UTC
(In reply to comment #6)
> (In reply to comment #4)
> > Created an attachment (id=245910) [details] [review] [details] [review]
> > build: Don't hard code the paths to girdir and typelibdir
> 
> Hm, that patch and especially the commit message doesn't make sense.

The commit message also just mentions what was changed, but not why. Maybe it would help to elaborate on what problem this patch was supposed to fix.