After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 697759 - Latest Gobject-introspection breaks Gnome-documents
Latest Gobject-introspection breaks Gnome-documents
Status: RESOLVED FIXED
Product: gobject-introspection
Classification: Platform
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gobject-introspection Maintainer(s)
gobject-introspection Maintainer(s)
Depends on:
Blocks: 697882
 
 
Reported: 2013-04-10 21:20 UTC by Rafael Fonseca
Modified: 2015-02-07 16:50 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
0001-girparser-Also-honor-legacy-c-prefix.patch (1.12 KB, patch)
2013-04-12 21:31 UTC, Colin Walters 		reviewed Details | Review
0002-typelib-Also-ignore-typelibs-with-empty-c-prefix.patch (897 bytes, patch)
2013-04-12 21:31 UTC, Colin Walters 		accepted-commit_now Details | Review

Description Rafael Fonseca 2013-04-10 21:20:02 UTC 
When using gobject-introspection from git, gnome-documents don't even start with the following error message:

"Unable to connect to tracker database: TypeError: Tracker.SparqlConnection is undefined"

Changing gobject-introspection back to release version 1.36.0 fixes the problem.

I'll try to bisect the responsible commit and update here later.

Let me know if you need any more information.
Comment 1 Rafael Fonseca 2013-04-10 21:46:40 UTC 
It seems like the commit 99a7287bb152 is the first to introduce the gnome-documents problem.
Comment 2 Colin Walters 2013-04-11 09:03:15 UTC 
Note that commit originated from https://bugzilla.gnome.org/show_bug.cgi?id=696155

I'll take a look at this, but it'll be painful for me because I can't run gnome-documents in gnome-ostree at the moment due to its dependency on evince.
Comment 3 Matthias Clasen 2013-04-12 09:51:23 UTC 
Can we revert this until it works ?
Comment 4 Colin Walters 2013-04-12 14:44:40 UTC 
Ok, this is because tracker has two gir/typelib files:

Tracker and TrackerMiner.  Tracker is generated from *vala* directly.  TrackerMiner comes from g-ir-scanner.  The bottom line is that TrackerMiner has a correct c:prefix of Tracker, but Tracker doesn't, causing us to abort the search.

We need to fix vala here.
Comment 5 Colin Walters 2013-04-12 14:47:10 UTC 
Cloned to vala https://bugzilla.gnome.org/show_bug.cgi?id=697882
Comment 6 Colin Walters 2013-04-12 21:30:53 UTC 
Ok this actually unearthed a chain of bugs.  Two patches for g-i attached here.
Comment 7 Colin Walters 2013-04-12 21:31:17 UTC 
Created attachment 241406 [details] [review]
0001-girparser-Also-honor-legacy-c-prefix.patch
Comment 8 Colin Walters 2013-04-12 21:31:38 UTC 
Created attachment 241407 [details] [review]
0002-typelib-Also-ignore-typelibs-with-empty-c-prefix.patch
Comment 9 Dieter Verfaillie 2013-04-15 13:23:41 UTC 
Review of attachment 241406 [details] [review]:

::: girepository/girparser.c
@@ +2873,3 @@
 	  shared_library = find_attribute ("shared-library", attribute_names, attribute_values);
 	  cprefix = find_attribute ("c:identifier-prefixes", attribute_names, attribute_values);
+          if (cprefix == NULL)

Hmm, maybe a comment here indicating it's for backward compatibility?
Otherwise OK for me
Comment 10 Dieter Verfaillie 2013-04-15 13:23:57 UTC 
Review of attachment 241407 [details] [review]:

OK
Comment 11 André Klapper 2015-02-07 16:50:44 UTC 
[Mass-moving gobject-introspection tickets to its own Bugzilla product - see bug 708029. Mass-filter your bugmail for this message: introspection20150207 ]