After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 695101 - bookshelf sidebar should set minimum width
bookshelf sidebar should set minimum width
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
unspecified
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2013-03-04 03:00 UTC by Jeremy Bicha
Modified: 2013-10-20 11:23 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Devhelp without horizontal scrollbar screenshot (53.50 KB, image/png)
2013-03-04 03:00 UTC, Jeremy Bicha
Details
Anjuta with devhelp plugin screenshot (72.15 KB, image/png)
2013-03-04 03:01 UTC, Jeremy Bicha
Details

Description Jeremy Bicha 2013-03-04 03:00:36 UTC
Created attachment 237921 [details]
Devhelp without horizontal scrollbar screenshot

Devhelp 3.7.90 with WebKit 1.10.2 (without WebKit2)

Devhelp needs a horizontal scrollbar when the sidebar isn't wide enough. See the attached screenshot.
Comment 1 Jeremy Bicha 2013-03-04 03:01:34 UTC
Created attachment 237922 [details]
Anjuta with devhelp plugin screenshot

It also affects Anjuta 3.7.90 with the devhelp plugin.
Comment 2 Adam Dingle 2013-04-01 10:37:58 UTC
I see this too with Devhelp built from git master and WebKit 1.11.92.

I personally might be able to live without a horizontal scrollbar if the side pane remained flush left when resized to be small, i.e. if the right side of each book title was cut off.  But as you can see in the screenshot Jeremy attached, the *left* side of each title is cut off, which makes the view very difficult to read.
Comment 3 Aleksander Morgado 2013-05-15 11:51:10 UTC
There are a couple of things to consider here...

The horizontal scrollbar should affect not only the list, but also the search box and buttons as well. If we end up removing the Current|All books buttons, this may not be needed, though, as we can make the searchbox narrower and that's it.

Then, for the list itself, we're ellipsizing the text of each cell (if it doesn't fit we add the '...'), and that's why automatic horizontal scrolling won't work if enabled in the GtkScrolledWindow (the cell won't request more width).

Also, we do the ellipsis in both the book tree and in the search hitlist. If we end up adding more columns to the hitlist (e.g. to show which book contains each hit), we do need to ellipsize each cell in the table, don't think we should have a horizontal scrollbar there...
Comment 4 Jeremy Bicha 2013-05-25 14:29:35 UTC
Another way to fix this is just to set a minimum width for the sidebar. Text does ellipsize from the right when the text is too long, but the text just goes missing (from the left!) when the sidebar is too narrow.
Comment 5 RobberPhex 2013-10-18 15:54:31 UTC
I think should add a horizontal scrollbar. The book name maybe very long.
Comment 6 Aleksander Morgado 2013-10-20 11:23:25 UTC
The removal of the [Current|All] filter buttons next to the the search box was now done; and I also pushed a fix to avoid the sidebar being shrunk further than the min width requested by its contents (therefore preventing text going missing from the left).

Marking as fixed.