After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 689516 - autogen.sh does not pass all arguments correctly to configure
autogen.sh does not pass all arguments correctly to configure
Status: RESOLVED FIXED
Product: gnome-online-accounts
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Online Accounts maintainer(s)
GNOME Online Accounts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-12-03 09:45 UTC by Evan Nemerson
Modified: 2012-12-04 13:50 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
build: fix passing arguments to configure from autogen.sh (558 bytes, patch)
2012-12-03 09:45 UTC, Evan Nemerson
none Details | Review
build: fix passing arguments to configure from autogen.sh (558 bytes, patch)
2012-12-03 20:33 UTC, Evan Nemerson
committed Details | Review

Description Evan Nemerson 2012-12-03 09:45:37 UTC
Created attachment 230510 [details] [review]
build: fix passing arguments to configure from autogen.sh

Some arguments, such as CFLAGS="-g -O2" are not passed correctly to configure.
Comment 1 Paolo Borelli 2012-12-03 13:14:03 UTC
I think it should use "$@" to properly handle dirs with spaces in the name
Comment 2 Evan Nemerson 2012-12-03 20:33:44 UTC
Created attachment 230571 [details] [review]
build: fix passing arguments to configure from autogen.sh

(In reply to comment #1)
> I think it should use "$@" to properly handle dirs with spaces in the name

Yes.  Sorry, I thought I had changed that.

Do you have any idea what the use case is (if there is one) for $*?  The only modules I've found so far which use it are g-o-a and udisks.  I understand the difference between $* and $@, just not why one would use $* here...
Comment 3 Paolo Borelli 2012-12-03 20:50:28 UTC
No use case. Someone somewhere used $* because it sort of worked and these modules cut&pasted from the wrong place :)
Comment 4 Debarshi Ray 2012-12-03 21:14:12 UTC
(In reply to comment #2)
> Do you have any idea what the use case is (if there is one) for $*?  The only
> modules I've found so far which use it are g-o-a and udisks.  I understand the
> difference between $* and $@, just not why one would use $* here...

Because g-o-a and udisks have the same author. ;-)
Comment 5 Debarshi Ray 2012-12-03 21:14:55 UTC
(In reply to comment #3)
> No use case. Someone somewhere used $* because it sort of worked and these
> modules cut&pasted from the wrong place :)

So what do you recommend?
Comment 6 Paolo Borelli 2012-12-03 21:59:32 UTC
(In reply to comment #5)> 
> So what do you recommend?

Evan's last patch looks perfect. I was just answering to his question
Comment 7 Debarshi Ray 2012-12-04 13:50:06 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.