After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688685 - daemon: catch thumbnail files in large directory as well
daemon: catch thumbnail files in large directory as well
Status: RESOLVED FIXED
Product: gvfs
Classification: Core
Component: daemon
git master
Other All
: Normal normal
: ---
Assigned To: gvfs-maint
gvfs-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-19 23:05 UTC by Debarshi Ray
Modified: 2013-09-02 14:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
daemon: Catch thumbnail files in large directory as well (2.71 KB, patch)
2012-11-19 23:07 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-11-19 23:05:30 UTC 
See bug 686895 against GIO for local files.
Comment 1 Debarshi Ray 2012-11-19 23:07:48 UTC 
Created attachment 229416 [details] [review]
daemon: Catch thumbnail files in large directory as well
Comment 2 Debarshi Ray 2013-09-02 13:33:38 UTC 
The current mismatch in the behaviour for local and remote files is hurting applications that create thumbnails for both remote and local URIs. As described in the glib commit (d681b581ff059fdf258b6f91b62cf1e474f2cc71):

    "Failing to do this would cause an application that creates large
    thumbnails by default to never find any value for
    G_FILE_ATTRIBUTE_THUMBNAIL_PATH, with no
    G_FILE_ATTRIBUTE_THUMBNAILING_FAILED set, which might cause the
    application to either think thumbnailing is still in progress, or
    blindly requeue thumbnail operations in a loop."

For example, the latest version of grilo-plugins gets you a larger sized thumbnail for Flickr content, and putting them in ~/.cache/thumbnails/large/... misleads gnome-photos into believing that the thumbnail could not be retrieved.

I don't mind adding a separate GFile attribute for specifically fetching the large thumbnail path, but until we do that we should make the behaviour consistent for 3.10.
Comment 3 Alexander Larsson 2013-09-02 14:07:05 UTC 
Review of attachment 229416 [details] [review]:

ack
Comment 4 Debarshi Ray 2013-09-02 14:13:27 UTC 
Comment on attachment 229416 [details] [review]
daemon: Catch thumbnail files in large directory as well

Pushed to master. Thanks for the review.