After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 688561 - don't scale up images more than 100%
don't scale up images more than 100%
Status: RESOLVED FIXED
Product: gnome-photos
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME photos maintainer(s)
GNOME photos maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2012-11-18 01:25 UTC by William Jon McCann
Modified: 2012-12-16 06:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
embed: Don't upscale images, but do downscale them if necessary (3.78 KB, patch)
2012-12-15 07:47 UTC, Debarshi Ray 		none Details | Review
embed: Don't upscale images, but do downscale them if necessary (4.78 KB, patch)
2012-12-15 08:30 UTC, Debarshi Ray 		committed Details | Review

Description William Jon McCann 2012-11-18 01:25:18 UTC 
I don't think we should scale up images to more than 100%. It looks pretty bad and it is misleading. We should still, of course, scale down images to fit.

We can have a different way of scaling explicitly.
Comment 1 Debarshi Ray 2012-12-15 07:47:13 UTC 
Created attachment 231613 [details] [review]
embed: Don't upscale images, but do downscale them if necessary

I don't if this is the correct way to do this, but it works for me.
Comment 2 Debarshi Ray 2012-12-15 08:30:51 UTC 
Created attachment 231614 [details] [review]
embed: Don't upscale images, but do downscale them if necessary
Comment 3 Debarshi Ray 2012-12-16 06:02:32 UTC 
Comment on attachment 231614 [details] [review]
embed: Don't upscale images, but do downscale them if necessary

Lets commit this for 3.7.3. We can always improve it later.