GNOME Bugzilla – Bug 687928
Handle yanking out of current video input
Last modified: 2018-05-22 15:52:48 UTC
If the camera being used to make the call is yanked out then empathy-call crashes. Instead it should continue with audio. If another camera is available it should use it for subsequent calls.
Created attachment 228482 [details] [review] empathy-call: Handle yanking out of current video input
Created attachment 228513 [details] [review] empathy-call: Handle yanking out of current video input This is a more complete patch. The previous one did not cover a few possible interactions.
Review of attachment 228513 [details] [review]: Looks good thanks! (both branches)
Not closing this yet, because I missed one case. If you hangup, then yank out the active camera, and then place a call without explicitly choosing another camera. It will causes a crash. The backtrace looks like this:
+ Trace 231147
The crash can be easily fixed by doing a: + if (priv->video_input == NULL) + create_video_input (self); + empathy_camera_menu_set_sensitive (priv->camera_menu, TRUE); ... but the problem is there is no visual indication of what the current camera is until you actually start the call. Do we care about that?
-- GitLab Migration Automatic Message -- This bug has been migrated to GNOME's GitLab instance and has been closed from further activity. You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/empathy/issues/613.