After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 687762 - Don't unref properties before creating the certificate
Don't unref properties before creating the certificate
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Auth client
3.6.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on:
Blocks:
 
 
Reported: 2012-11-06 14:30 UTC by Debarshi Ray
Modified: 2012-11-06 14:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
auth-client: Don't unref properties before creating the certificate (1.14 KB, patch)
2012-11-06 14:31 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-11-06 14:30:01 UTC 
The cert_object_path is fetched from properties as "&o", which means that it borrows the pointer. So unreffing properties means that cert_object_path won't be valid any more.
Comment 1 Debarshi Ray 2012-11-06 14:31:45 UTC 
Created attachment 228251 [details] [review]
auth-client: Don't unref properties before creating the certificate
Comment 2 Guillaume Desmottes 2012-11-06 14:39:43 UTC 
Review of attachment 228251 [details] [review]:

Ooops, nice catch.

Please merge to 3.6 and master.