After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686314 - Unref the list of FsElementAddedNotifiers on fs-conference-removed
Unref the list of FsElementAddedNotifiers on fs-conference-removed
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
3.6.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
Depends on: 686311
Blocks:
 
 
Reported: 2012-10-17 16:31 UTC by Debarshi Ray
Modified: 2012-10-18 09:23 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
empathy-call: Free the FsElementAddedNotifiers on fs-conference-removed (934 bytes, patch)
2012-10-17 16:33 UTC, Debarshi Ray 		none Details | Review
empathy-call: Free the FsElementAddedNotifiers on fs-conference-removed (942 bytes, patch)
2012-10-18 08:57 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2012-10-17 16:31:20 UTC 
Currently, the list of FsElementAddedNotifiers (ie. priv->notifiers) is only freed when the EmpathyCallWindow is destroyed. However, there is no reason to keep them around since the pipeline has already been reset when CallStateChanged (->END) is received. We can free it up on fs-conference-removed as the notifiers were added from fs-conference-added.

(I am actually wondering why we need a list of notifiers? We have only one pipeline at any point of time.)
Comment 1 Debarshi Ray 2012-10-17 16:33:27 UTC 
Created attachment 226657 [details] [review]
empathy-call: Free the FsElementAddedNotifiers on fs-conference-removed
Comment 2 Debarshi Ray 2012-10-18 08:57:15 UTC 
Created attachment 226714 [details] [review]
empathy-call: Free the FsElementAddedNotifiers on fs-conference-removed
Comment 3 Sjoerd Simons 2012-10-18 09:18:29 UTC 
Review of attachment 226714 [details] [review]:

looks good
Comment 4 Debarshi Ray 2012-10-18 09:23:29 UTC 
Pushed to both master and gnome-3-6.