After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 686311 - Tries to remove fsrtpconference element from wrong pipeline
Tries to remove fsrtpconference element from wrong pipeline
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: VoIP
3.6.x
Other All
: Normal normal
: ---
Assigned To: empathy-maint
empathy-maint
: 670585 (view as bug list)
Depends on:
Blocks: 686314
 
 
Reported: 2012-10-17 15:52 UTC by Debarshi Ray
Modified: 2012-11-08 23:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
empathy-call: Unparent the conference instead of trying to remove it (996 bytes, patch)
2012-10-17 15:57 UTC, Debarshi Ray
none Details | Review
empathy-call: Clean up the TfChannel before resetting the pipeline (1.75 KB, patch)
2012-10-18 08:44 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2012-10-17 15:52:41 UTC
When a call is disconnected, empathy-call throws the following warning:
(empathy-call:27142): GStreamer-WARNING **: Element 'fsrtpconference0' is not in bin 'pipeline1'

This is because it tries to remove the fsrtpconference element from the wrong pipeline. The pointer to the pipeline that it was a part of, ie. priv->pipeline, has now been replaced by a new one in empathy_call_window_disconnected when the CallStateChanged (->ENDED) signal was received. This new pipeline does not have the conference element.

(Earlier we used to get an extra CallStateChanged (->ENDED), but not anymore:
https://bugs.freedesktop.org/show_bug.cgi?id=56044)
Comment 1 Debarshi Ray 2012-10-17 15:57:19 UTC
Created attachment 226652 [details] [review]
empathy-call: Unparent the conference instead of trying to remove it
Comment 2 Debarshi Ray 2012-10-18 08:44:53 UTC
Created attachment 226713 [details] [review]
empathy-call: Clean up the TfChannel before resetting the pipeline
Comment 3 Debarshi Ray 2012-10-18 08:58:05 UTC
From #empathy on GIMPNet:

08:45 <rishi> sjoerd: What do you think: https://bugzilla.gnome.org/show_bug.cgi?id=686311 ?
08:47 <sjoerd> I assume you tested it quite a bit ? :)
08:48 <rishi> sjoerd: Yes.
08:48 <sjoerd> then it's ok for me ;)
Comment 4 Debarshi Ray 2012-10-18 09:11:15 UTC
Pushed to both master and gnome-3-6.
Comment 5 Debarshi Ray 2012-11-08 23:09:14 UTC
*** Bug 670585 has been marked as a duplicate of this bug. ***